logo       

Re: [PATCH 1/2] alpha: use .data.init_task instead of .data.init_thread.: msg#12048

linux-kernel

Subject: Re: [PATCH 1/2] alpha: use .data.init_task instead of .data.init_thread.

On 07/31/2009 01:56 PM, Tim Abbott wrote:
- /* Note 2 page alignment above. */
- .data.init_thread : {
- *(.data.init_thread)
- }

NACK.

You can change the section name, sure, but you cannot remove the 2 page alignment that we had via the alignment at the end of the init sections. You'll break current_thread_info which is always computed as (kernel-stack-pointer & -(2*PAGE_SIZE)).

Similarly it is *not* a bug that the page_aligned sections were before data, because we already knew we had 2 page alignment from the end of init + 2 pages of init_thread.


r~
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Google Custom Search

News | Mail Home | sitemap | FAQ | advertise