Re: Want feedback on Mongrel patch for handling partial PUT requests

On Jan 22, 2007, at 8:31 PM, Ezra Zygmuntowicz wrote:

>
>       I would like to play with this a bit as it changes the way the
> mongrel_upload_progress does a request_aborted to cleanup. That
> plugin relies on the @body being nil to work but I think that could
> be worked around in your approach.
>
>       Can you please send an svn diff of this file? I don't feel like copy
> pasting all that jazz.
>
> Thanks
> -Ezra
>
>
> On Jan 22, 2007, at 5:27 PM, cremes.devlist-ee4meeAH724@xxxxxxxxxxxxxxxx 
> wrote:
>
>> By default, Mongrel will delete the HTTP request body and short
>> circuit calling any handlers if a request is interrupted or
>> incomplete. Unfortunately, this breaks any attempt to correctly
>> handle a partial PUT. (BTW, PUT is *way* more efficient for uploads
>> compared to POST which requires a MIME parsing step.) So, about a
>> month ago I wrote up some patches to Mongrel 0.3.18 that allowed
>> Mongrel to properly handle partial PUT requests. I sent the patch &
>> tests to Zed for comment but never really heard back.
>>
(snip)

I emailed the patches to Ezra. If anyone else wants them, please  
email me off list. I found a few bugs & problems after I actually  
typed this stuff in and ran it. Those bugs are fixed in the patches.

cr