|
Bug fix for html/fillinform: msg#01221lang.ruby.general
Hello, I found a bug in html/fillinform. This form will not get filled properly: <select name="test"> <option value="1">one</option> <option value="2">two</option> </select> The reason is that the code for processing <option value="*"> has a bug. Here is the fix: Change line 131 (tag.attr['selected'] = true) to: chk = true Change line 133 (tag.attr.delete('selected')) to: chk = false Also, regarding line 115: option_tag.attr = (tag.attr ? tag.attr : {}) I think that this would better be written as: option_tag.attr = tag.attr || {} P.S. The webpage at http://www.0xfa.com/~ikechin/ruby/html-fillinform-0.22/fillinform.rd writes your e-mail address incorrectly as ikechin@xxxxxxxx ("Oxfa" != "0xfa").
|
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| Previous by Date: | Re: Q) about singleton methods and access control, Christoph |
|---|---|
| Next by Date: | Re: ambiguity backtrack - accessors and persistent locals, dblack |
| Previous by Thread: | ATTN: Vim/Ruby users. Updates to indent/ruby.vim and ftplugin/ruby.vim., Gavin Sinclair |
| Next by Thread: | Glade Shortcut Keys, Tom Sawyer |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
| News | FAQ | advertise |