Re: Capistrano Git bugfix + patch. Looking for +1 comments on the bug report so I can Verify

Coolio.  Look forward to it!

Glenn

On Dec 15, 5:40 pm, Jamis Buck <ja...-uHoyYlH2B+GakBO8gow8eQ@xxxxxxxxxxxxxxxx> 
wrote:
> It will be done!
>
> - Jamis
>
> P.S. But not tonight. I'll probably spend a few hours sometime in the
> next week or two and do a ticket-processing marathon. Might have a new
> cap out before the end of the year...but I won't make any guarantees!
>
> On Dec 15, 2007, at 5:57 PM, Glenn Rempe wrote:
>
>
>
> > PS - I added a test assertion to the patch to verify that this bug
> > stays fixed.  I currently have two +1's (from two of the authors of
> > the Cap Git code) and need one more.  Who's with me. :-)  Jamis?  :-)
>
> > Thanks.
>
> > On Dec 15, 3:10 pm, Glenn Rempe 
> > <glenn.re...-Re5JQEeQqe8AvxtiuMwx3w@xxxxxxxxxxxxxxxx> wrote:
> >> Hi all,
>
> >> I submitted a bugfix and patch to fix a bug with the Git support in
> >> Capistrano today.  You can find the bug here:
>
> >>http://dev.rubyonrails.org/ticket/10515
>
> >> If you are using Git support in Capistrano please take a look, try
> >> out
> >> the fix, and please add a +1 in the bug comments (following the
> >> instructions here:http://dev.rubyonrails.org/) so I can get it
> >> accepted and applied to the next Capistrano release.  All rake tests
> >> continue to pass on Capistrano with this fix applied.
>
> >> Bug Summary:
>
> >> The 'sync' method in the Git SCM did not respect the setting
> >> of :scm_command and tried to find the 'git' executable on the remote
> >> machine's path. If git was in a non-standard location or not on the
> >> remote path an exception would occur. This patch makes the 'sync'
> >> method behave consistently with other Git SCM methods in that it will
> >> use the :scm_command value to execute the needed git command from the
> >> specified location.
>
> >> e.g. will now remotely execute '/opt/local/bin/git ...' instead of
> >> 'git ...' when :scm_command is set to '/opt/local/bin/git'.
>
> >> Thanks!
>
> >> Glenn
> > >
>
>
>  smime.p7s
> 3KDownload