Re: XML::LibXSLT registered functions: a preliminary fix

At 17:58 +0100 12/11/03, Petr Pajas wrote:
> Elizabeth Mattijsen <liz@xxxxxxxxxx> writes:
>  > I don't think that's what I'm seeing: to test I just redefined
> >  XML::LibXML::Node::DESTROY and just had it display the refaddr of the
> >  object being destroyed.  As soon as the Perl sub is finished, the
> >  "cloned" node is destroyed, which apparently frees up libxml
>  > structures when it shouldn't (judging from the valgrind output).
> Hm, I think I found the problematic lines. Check the attached patch
> (without your module).

That indeed fixes the problem for the example program.


> I don't say it is a fix, because I remove three lines the original
> purpose of which I don't know. But the fact is, that your problematic
> code passes valgrind now and also all self test pass (while before
> 10functions.t caused a sigsegv on my setup as well as somebody else's
> from the list - most probably the same issue). That's a good knews,
> isn't it :-)

Indeed.  Less is more!     ;-)   Now, if people would document their 
code, we would know what the function was of those 3 lines...  ;-(



Liz
_______________________________________________
Perl-XML mailing list
Perl-XML@xxxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe: http://listserv.ActiveState.com/mailman/mysubs