Re: Test me please: P/PE/PETDANCE/Test-Harness-2.57_06.tar.gz

On Sun, Apr 23, 2006 at 01:02:00AM -0500, Andy Lester wrote:
> I'm approaching the end of this release cycle.  I really want to get  
> this released.
> 
> I've removed the meaningless percentages of tests that have failed.   
> If you rely on the output at the end, it's different now.
> 
> xoa
> >
> >  file: $CPAN/authors/id/P/PE/PETDANCE/Test-Harness-2.57_06.tar.gz
> >  size: 69114 bytes
> >   md5: 41efc0985146e4f7d678ec7cb9b59047

I have merged this in to blead with change 27940. (Because I want the speedup)

Specifically blead is now identical (Unless I messed up) which means that
this change got removed before I committed:

--- Test-Harness-2.57_06/lib/Test/Harness.pm    Sun Apr 23 06:53:11 2006
+++ perl/lib/Test/Harness.pm    Sun Apr 23 21:23:30 2006
@@ -38,7 +38,8 @@
 
 =cut
 
-$VERSION = '2.57_06';
+$VERSION = "2.57_06";
+$VERSION = eval $VERSION;
 
 # Backwards compatibility for exportable variable names.
 *verbose  = *Verbose;

And this change did get committed:

==== //depot/perl/lib/Test/Harness/t/version.t#2 - 
/home/nick/p4perl/perl/lib/Test/Harness/t/version.t ====
--- /tmp/tmp.27775.0    Sun Apr 23 21:25:55 2006
+++ /home/nick/p4perl/perl/lib/Test/Harness/t/version.t Sun Apr 23 21:23:28 2006
@@ -19,5 +19,5 @@ BEGIN {
 }
 
 my $ver = $ENV{HARNESS_VERSION} or die "HARNESS_VERSION not set";
-like( $ver, qr/^2.\d\d(_?\d\d)?$/, "Version is proper format" );
+ok( $ver =~ /^2.\d\d(_\d\d)?$/, "Version is proper format" );
 is( $ver, $Test::Harness::VERSION );

Note that I removed the ? from the _ inside the regexp, which was added
in http://public.activestate.com/cgi-bin/perlbrowse?patch=27925


I felt it better to get the code perfectly in sync than to preserve minor
recent (possible) fixes and have to keep track of the fork.

Nicholas Clark