On Saturday, February 15, 2003, at 08:20 AM, Brian King wrote:
I only changed them if they were too small to hold the whole
histogram, or, in the case of HISTOGRAM_CHAR, if it was more than one
character.
I didn't like the idea of omitting values (I do like The
Who, myself...), and was unable to use fractional values because we're
using ASCII-art. Maybe I missed a better solution for that problem,
here.
I don't mean any offense at all, but I don't think this is the way to
go. If I set a global width and height variable and then called a
function that returned values outside this range, it would likely break
my code since it didn't give me what I expected. I believe this is why
the problem stated that the output should be scaled.
As another stylistic clue, a variable name in all capital letters is
unusually intended to be a constant value. The all-caps name is
supposed to be a signal to users against changing it.
Well, again I didn't mean any offense, I'm just giving my take on the
problem.
James
|
