Re: cvs commit: parrot/ops cmp.ops

Sam Ruby <rubys@xxxxxxxxxxxx> wrote:
> cvsuser     04/12/23 04:44:05

>   
>   Note: change to op issame to make use of VTABLE_is_same.
    
>    inline op issame(out INT, in PMC, in PMC) {
>   -    $1 = $2 == $3;
>   +    if ($2 == $3)
>   +        $1 = 1;
>   +    else
>   +        $1 = VTABLE_is_same(interpreter, $2, $3);
>        goto NEXT();
>    }
    
This doesn't really help for what you might achieve:

>>> id(2) == id(1+1)
True
>>> id(101) == id(100+1)
False

Second: before such core changes I'd prefer some discussion
on the list about possible implications. Did you check that
all implementations of the is_same vtable are sane?
Such changes can break code, if suddenly a vtable is called
that wasn't before.

Please send non-trivial core Patches to the list for review.

Thanks,
leo