Yitzchak Scott-Thoennes <sthoenna@xxxxxxx> wrote:
> Without it, the build is going fail for the first person who
> runs with </dev/null (in the existing code) or PERL_MM_USE_DEFAULT=1
> (with my patch to prompt()).
>
> Might as well force the module author to not make this mistake.
True... we're *almost* there; I'd change this:
die "y_n() called without y or n default" unless ($_[1]||"")=~/[yn]/i;
To:
die "y_n() called without y or n default" unless ($_[1]||"")=~/^[yn]/i;
- Tyler
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
|
