logo       
Google Custom Search
    AddThis Social Bookmark Button
-->

Re: [Module::Build] Re: CPANPLUS::Dist::Build's prereq resolving: msg#00042

Subject: Re: [Module::Build] Re: CPANPLUS::Dist::Build's prereq resolving

On Sep 24, 2005, at 3:26 AM, Jos I. Boumans wrote:

I see where you're going, and it seems like a good idea to me. However, I'm
a bit unsure about this line:


+ if (CPANPLUS::inc::vcmp($args{version}, $args{modobj}->version) > 0) {

as CPANPLUS::inc is a 'magic' class that gets added sort out to load bundled prereqs, and it doesn't hold a vcmp() function as far as i know.

It does have one, ever since I patched one in a few weeks ago. =) However, you're right, it was meant to be internal-only, not exposed to other packages.

It would probably be best to take the vcmp() function out of inc.pm and put it somewhere like a utility package that both inc.pm and Dist.pm could access.

 -Ken



-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php


<Prev in Thread] Current Thread [Next in Thread>