logo       

WWW::Mechanize -- bug in find_all_images: msg#00015

Subject: WWW::Mechanize -- bug in find_all_images
Hi Andy,

This little script:

   use WWW::Mechanize;

   my $mech = WWW::Mechanize->new();
   $mech->get ( "http://news.google.com"; );
   my @tImages = $mech->find_all_images( url_regex => qr/imgurl=/ );

Produces the following output:
   Use of uninitialized value in pattern match (m//) at .../WWW/Mechanize.pm 
line 1053.
   Use of uninitialized value in pattern match (m//) at .../WWW/Mechanize.pm 
line 1053.
   Use of uninitialized value in pattern match (m//) at .../WWW/Mechanize.pm 
line 1053.
   ...
This patch to v1.30 fixes the problem:

--- Mechanize.pm-1.30   2007-06-16 22:42:27.000000000 +0200
+++ Mechanize.pm        2007-06-16 22:59:21.000000000 +0200
@@ -1049,10 +1049,11 @@
    # No conditions, anything matches
    return 1 unless keys %$p;

-    return if defined $p->{url}           && !($image->url eq $p->{url} );
-    return if defined $p->{url_regex}     && !($image->url =~ $p->{url_regex} 
);
-    return if defined $p->{url_abs}       && !($image->url_abs eq 
$p->{url_abs} );
-    return if defined $p->{url_abs_regex} && !($image->url_abs =~ 
$p->{url_abs_regex} );
+    return if defined $p->{url}           && !($image->url  && $image->url eq 
$p->{url} );                     #[1]
+    return if defined $p->{url_regex}     && !($image->url  && $image->url =~ 
$p->{url_regex} );
+    return if defined $p->{url_abs}       && !($image->url_abs  && 
$image->url_abs eq $p->{url_abs} );
+    return if defined $p->{url_abs_regex} && !($image->url_abs_regex  && 
$image->url_abs =~ $p->{url_abs_regex} );
+
    return if defined $p->{alt}           && !(defined($image->alt) && $image->alt 
eq $p->{alt} );
    return if defined $p->{alt_regex}     && !(defined($image->alt) && $image->alt 
=~ $p->{alt_regex} );
    return if defined $p->{tag}           && !($image->tag && $image->tag eq 
$p->{tag} );


I'm not sure if all 4 lines really need the change - the second line would fix my problem - but I put them in to be safe :-)

Cheers,

Peter

<Prev in Thread] Current Thread [Next in Thread>
Google Custom Search

Recently Viewed:
audio.irate.dev...    yellowdog.gener...    ietf.ips/2002-0...    xfree86.fonts/2...    busybox/2003-07...    emacs.jdee/2004...    linux.mandrake....    hardware.microc...    user-groups.lin...    science.analysi...    version-control...    db.filemaker.de...    cluster.openmos...    mail.eyebrowse....    text.xml.xerces...    kde.devel.kwrit...    finance.moneyda...    gcc.regression/...    network.routing...    os.freebsd.deve...    recreation.radi...    qnx.openqnx.dev...    python.xml/2002...   
Home | blog view | USPTO Patent Archive | advertise | OSDir is an inevitable website. super tiny logo

Free Magazines

Cisco News
Receive a free quarterly e-newsletter with exclusive articles on how Cisco IT uses its own products and solutions to enable the business.
subscribe

Systems Management News, the newspaper for IT systems administration and data center managers! Each issue of Systems Management News is chock-full of news and analysis to help you understand what's happening in your field.
subscribe

The Enterprise Newsweekly eWeek is the essential technology information source for builders of e-business.
subscribe

Oracle Magazine Oracle Magazine contains technology strategy articles, sample code, tips, Oracle and partner news, how to articles for developers and DBAs, and more. Oracle (NASDAQ: ORCL) is the world's largest enterprise software company.
subscribe

Total Telecom Total Telecom is "The Economist of the communications industry".
subscribe