On Thursday 16 November 2006 11:43, Shlomi Fish wrote:
> On Wednesday 15 November 2006 22:59, Sam Tregar wrote:
> > On Wed, 15 Nov 2006, Shlomi Fish wrote:
> > > A question if I may. Why weren't the tests and other changes that
> > > were done to the Phalanx work on HTML-Template:
> > >
> > > * http://svn.perl.org/phalanx/HTML-Template/
> > > * http://hew.ca/yapc/phalanx/slides/TABLE_OF_CONTENTS.html
> > >
> > > Integrated into the mainline HTML-Template at:
> > >
> > > https://svn.sourceforge.net/svnroot/html-template/
> >
> > Lack of motivation, I suppose. As far as I know they never found or
> > fixed a bug in HTML::Template.
>
> Well, the main point of a full test coverage is to prevent *future* bugs.
>
> > At this point their repo is out of
> > date and it would be a painful process to do the merge.
> >
> > Patches welcome, of course. Beware though, I have a history of
> > rejecting changes to existing tests - if it ain't broke... New tests
> > are always welcome though!
>
> Check:
>
> http://www.shlomifish.org/Files/files/code/perl/HTML-Template/h-t-phalanx.d
>iff.bz2
>
> Took me exactly 10 minutes to forward port the patch from the Phalanx
> repository. So it wasn't such a painful process. :-D
>
Hmmm... I spoke too soon. The first incarnation of the patch did not pass the
tests. I now have a better patch at the same URL:
http://www.shlomifish.org/Files/files/code/perl/HTML-Template/h-t-phalanx.diff.bz2
Please apply it instead.
Regards,
Shlomi Fish
---------------------------------------------------------------------
Shlomi Fish shlomif@xxxxxxxxxxx
Homepage: http://www.shlomifish.org/
Chuck Norris wrote a complete Perl 6 implementation in a day but then
destroyed all evidence with his bare hands, so no one will know his secrets.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
|
