Not a comment on the bug, just on manner in which it was reported.
1) Nopastes expire eventually
2) You dont have any tests.
Please re-create your patch to include (failing) test cases, and then
attach it/append to the mail.
Ash
On 7 Dec 2007, at 23:15, James Kiser wrote:
I came across an issue when trying to slice a paged result set.
Basically, it boils down to the offset not being calculated properly
when slicing a paged result set.
I wrote a patch (diff: http://scsys.co.uk:8001/11287) that corrects
this issue and have tested the following (order of operation is right
to left):
+ sliced result set
+ paged result set
+ paged, paged result set
+ sliced, paged result set
+ paged, sliced result set
+ sliced, paged, sliced result set
+ sliced, sliced, paged, sliced result set
+ paged, paged, sliced result set
+ sliced, paged, paged, sliced result set
+ paged, sliced, paged, paged, sliced result set
I plan on writing automated tests but wanted to get feedback/approval
from the list before moving forward.
Thanks,
James
_______________________________________________
List: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbix-class
IRC: irc.perl.org#dbix-class
SVN: http://dev.catalyst.perl.org/repos/bast/DBIx-Class/
Searchable Archive: http://www.grokbase.com/group/dbix-class@xxxxxxxxxxxxxxxxx
|
