Inlined
Currently I am looking at the completion engine since it seems that
it can
use that cursed Manager class. There shall be some reason why
Alejandro did not
use some derived stuff (can be a historical reason), so I will not
dare to move that
way before it is cleaned up. I mean when Alejandro will be able to
remove that
code duplication, I will know that it would be usable for mere
mortals as me... :)
What do you exactly mean with 'code duplication'? I know there's some
stuff that have been moved to the Manager class, and I want to get rid
of it (maybe having the compiler init directly in Manager). However,
most of the things are not as in normal Manager, that's wh they remain
in Engine. If you have any other suggestions, feel free to post it
here, I'll try to do my best to improve the Completion Engine.
However, what do you exactly need? Lexer or parser is not available
through Completion Engine, but just type tree and method completion.
Seems that I was not crystal clear (happens a lot :)
I meant that you were able to make your own manager class working and it
seems that the initialization almost duplicates the code in the Manager
class. As Nazgul said he will refactor the code further to eliminate the
code duplication. However meantime I will copy your code for my parser
stuff because I simply cannot decipher exactly what is needed to make
that ManagerClass working... So no suggestions here, I have just lost in
the code :(
A little suggestion for your refactoring work: it would be cool if
you could remove all
the command line baggage from the Manager (compiler) classes and use
them only in
ncc.exe. I mean: progressbar, colors, etc. So it should work that all
the text IO handling
would happen interfaces and ncc.exe would use some sink to create the
text from that
which you put to the console. That way for example msbuild should not
parse the formatted
output not to mention the completion and future lexer/parser...
Engine has a Output rpoperty where you can directly receive the text
the compiler sends. However, it still needs parsing :-(
This suggestion was directed to Malekith and Nazgul since they are who
refactor the compiler right now.
If they implement it that way then neither the completion engine not the
msbuild stuff would need to parse the errors
(nor the compiler service when opening winforms in the designer nor my
parse stuff, etc...)
| 