logo       

Re: [jQuery] Greybox Redux (Reworked) (Demo): msg#01217

lang.javascript.jquery

Subject: Re: [jQuery] Greybox Redux (Reworked) (Demo)

I like your work. Here are a few suggestions.

If the link to activate the greybox is near the bottom of the page and the page
had to be scrolled to show the link, the greybox will appear not in the middle
of the visible window but back up near the top.

If the page has scrollbars and the user scrolls the page while the greybox is
visible the overlay is shown to not cover the entire page.

A horizontal scroll bar appears in FF.

If the page is scrolled with the greybox visible the greybox does not recenter
itself.

Erin

>Hi, the greybox redux (reworked) demo can be found here:
>
>http://foofiles.com/2006/10/13/greybox/test.html
>
>Fixes from last post to now:
>
>1. The greybox.js was reworked (again) because I had a big brain fart:
>links with different options in the same document walked over
>eachother, I had previously only tested one options configuration at a
>time per document. This is fixed, see example.
>2. The overlay in IE was messed up and missed by me. It was caused by
>some change between "/src/jquery-latest.js" (referenced by the
>original greybox redux code) and jquery-1.0.2.js (referenced by the
>reworked code). My bad, but I fixed this problem by redoing the
>overlay calculation... and we no longer need the overlay images.
>3. Tested using jquery-1.0.2.js
>4. Tested in IE (6.0.2900.2180)
>5. Tested in Firefox (1.5.0.7)
>6. Tested in Safari 2.0.4 (419.3)
>
>tgz'd source at: http://foofiles.com/2006/10/13/greybox-reworked.tgz
>
>Please feel free to copy and host the files on jquery if you want.
>
>Cheers,
>Ben
>
>--
>Blog: http://badpopcorn.com/
>Homepage: http://foofiles.com/
>
>_______________________________________________
>jQuery mailing list
>discuss@xxxxxxxxxx
>http://jquery.com/discuss/


<Prev in Thread] Current Thread [Next in Thread>
Google Custom Search

News | FAQ | advertise