Re: [Konsole-devel] Review Request: Patch for command-line option to read tab titles and tab commands from file

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1079/#review1670
-----------------------------------------------------------


I like the idea.  I think the syntax might be a little bit limiting though for 
expansion in the future.  For example, another user might decide that they want 
to specify tabs across multiple windows at once or specify additional options 
for a tab such as the profile to use for that tab.  There is no need to 
implement those features right now but it would be nice not to have to break 
existing files were such features to be added in future.

An alternative would be:

tab title:<tab title format> command:<command to execute> profile:<profile to 
use>

Where each of these is optional.  Regarding the command-line argument, I 
suggest using --tabs-from-file instead of --tabsfromfile for readability and 
also add a short version.

- Robert


On 2009-07-19 15:00:58, Thomas Dreibholz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1079/
> -----------------------------------------------------------
> 
> (Updated 2009-07-19 15:00:58)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> The attached patch introduces the new command line option "-tabsfromfile 
> <filename>" to konsole. On startup, konsole reads the file which contains one 
> line for each tab to be created. Syntax is "<tab title>: <command> <args> 
> ..."; comment lines start with '#'. This new option can e.g. be used to 
> conveniently open ssh connections to a pool of PCs; with one tab for each PC. 
> Such a configuration file could look like this:
> # SSH sessions to all Network Testbed PCs
> Control: ssh -CX user@xxxxxxxxxxxxxxxxxxxxx
> West:    ssh -CX user@xxxxxxxxxxxxxxxxxx
> North:   ssh -CX user@xxxxxxxxxxxxxxxxxxx
> South:   ssh -CX user@xxxxxxxxxxxxxxxxxxx
> East:    ssh -CX user@xxxxxxxxxxxxxxxxxx
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/konsole/src/Application.h 999085 
>   /trunk/KDE/kdebase/apps/konsole/src/Application.cpp 999085 
>   /trunk/KDE/kdebase/apps/konsole/src/main.cpp 999085 
> 
> Diff: http://reviewboard.kde.org/r/1079/diff
> 
> 
> Testing
> -------
> 
> Tested with SVN revision 999263.
> 
> 
> Thanks,
> 
> Thomas
> 
>

_______________________________________________
konsole-devel mailing list
konsole-devel@xxxxxxx
https://mail.kde.org/mailman/listinfo/konsole-devel