[Kernel-janitors] [PATCH] eicon/platform: replace schedule_timeout() with msleep() [corrected]

On Sat, Jul 24, 2004 at 08:17:51AM +0200, Armin Schindler wrote:
> On Fri, 23 Jul 2004, Nishanth Aravamudan wrote:
> > I would appreciate any comments from the janitors list.
> >
> > Thanks,
> > Nish
> >
> >
> > Depends-on: Patches to eicon/capifunc, io, mntfunc, os_4bri, os_bri,
> > os_pri, which replace invocations of diva_os_sleep() and diva_os_wait()
> > with msleep() and mdelay() respectively. Will not compile without those
> > patches.
> 
> What is the reason for your patches ?
> 
> Most of the drivers code is 'common-' code, used in other OSes too.
> So to maintain all of this, wrapper functions like diva_os_*() make it
> easier and I don't like to change that.
> 
> If necessary, the inline function itself should be changed, not the main
> code.

I have made this change specifically. Please find the new patch below.
All of the previous eicon patches can be ignored, then, and just this
one applied.

Thanks,
Nish


--- linux-vanilla/drivers/isdn/hardware/eicon/platform.h        2004-06-15 
22:19:43.000000000 -0700
+++ linux-dev/drivers/isdn/hardware/eicon/platform.h    2004-07-26 
09:52:31.000000000 -0700
@@ -214,10 +214,7 @@ void diva_os_free_message_buffer(diva_os
 */
 static __inline__ void diva_os_sleep(dword mSec)
 {
-       unsigned long timeout = HZ * mSec / 1000 + 1;
-
-       set_current_state(TASK_UNINTERRUPTIBLE);
-       schedule_timeout(timeout);
+       msleep(mSec);
 }
 static __inline__ void diva_os_wait(dword mSec)
 {

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@xxxxxxxxxxxxxx
http://lists.osdl.org/mailman/listinfo/kernel-janitors