On Sun, 04 Jul 2004, Michael Veeck wrote:
> Patch (against 2.6.7) removes unnecessary min/max macros and changes
> calls to use kernel.h macros instead.
>
> Feedback is always welcome
> Michael
>
>
>
>
>
>
>
> --- linux-2.6.7-old/drivers/char/esp.c 2004-07-04 11:04:13.000000000
> +0200
> +++ linux-2.6.7-new/drivers/char/esp.c 2004-07-04 15:03:22.346728056
> +0200
> @@ -19,7 +19,7 @@
> *
> * rs_set_termios fixed to look also for changes of the input
> * flags INPCK, BRKINT, PARMRK, IGNPAR and IGNBRK.
> - * Bernd Anh?upl 05/17/96.
> + * Bernd Anh???pl 05/17/96.
> *
> * --- End of notices from serial.c ---
> *
utf8?
> @@ -140,7 +140,7 @@
>
> static void change_speed(struct esp_struct *info);
> static void rs_wait_until_sent(struct tty_struct *, int);
> -
> +
> /*
> * The ESP card has a clock rate of 14.7456 MHz (that is, 2**ESPC_SCALE
> * times the normal 1.8432 Mhz clock of most serial boards).
space fix
> @@ -150,10 +150,6 @@
> /* Standard COM flags (except for COM4, because of the 8514 problem) */
> #define STD_COM_FLAGS (ASYNC_BOOT_AUTOCONF | ASYNC_SKIP_TEST)
>
> -#ifndef MIN
> -#define MIN(a,b) ((a) < (b) ? (a) : (b))
> -#endif
> -
> /*
> * tmp_buf is used as a temporary buffer by serial_write. We need to
> * lock it in case the memcpy_fromfs blocks while swapping in a page,
real min max stuff!
please do not random "fixes" in parallell,
if a file really needs white space fixes use automatic tool for that.
thanks maks
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@xxxxxxxxxxxxxx
http://lists.osdl.org/mailman/listinfo/kernel-janitors
|
