On Fri, 23 Jul 2004 21:12:25 -0400, Mark Hollomon
<markhollomon@xxxxxxxxxxx> wrote:
> I think this patch will result in delays 10 times too long.
>
>
> Nishanth Aravamudan wrote:
> >
<snip>
>
> ms seems to be a number that expresses an interval in units of 1/10 of a
> millisecond.
>
<snip>
>
> But this would use it as a delay in milliseconds.
Ok, thanks, I wasn't sure about this - I had posted a while ago about
the weird conversion because I couldn't quite decipher what it was
intended to achieve. Looking over the math, I think I agree with you.
I will re-submit this patch soon. BTW, doesn't that seem kind of
confusing? - The delays are in terms of 1, 5 and 10 tenths of a
millisecond? If that's the case, then this patch is pretty much
useless (it makes sense to use msleep() with long delays, things
countable in msecs). I suppose I could re-patch so that the value of
SAA7146_I2C_DELAY is in msecs and then use msecs_to_jiffies() in
my_wait(). Thanks again!
-Nish
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@xxxxxxxxxxxxxx
http://lists.osdl.org/mailman/listinfo/kernel-janitors
|
