logo       

[Kernel-janitors] [PATCH] isdn/hisax: replace schedule_timeout() with mslee: msg#00250

Subject: [Kernel-janitors] [PATCH] isdn/hisax: replace schedule_timeout() with msleep()
I would appreciate any comments from the janitors list.

Thanks,
Nish



Applys-to: 2.6.7

Description: Replace schedule_timeout() with msleep() to guarantee the
task delays the desired time.

Signed-off-by: Nishanth Aravamudan <nacc@xxxxxxxxxx>


--- linux-vanilla/drivers/isdn/hisax/config.c   2004-06-16 05:19:52.000000000 
+0000
+++ linux-dev/drivers/isdn/hisax/config.c       2004-07-02 18:13:46.000000000 
+0000
@@ -849,9 +849,8 @@ static int init_card(struct IsdnCardStat
        }
        while (cnt) {
                cs->cardmsg(cs, CARD_INIT, NULL);
-               set_current_state(TASK_UNINTERRUPTIBLE);
                /* Timeout 10ms */
-               schedule_timeout((10 * HZ) / 1000);
+               msleep(10);
                printk(KERN_INFO "%s: IRQ %d count %d\n",
                       CardType[cs->typ], cs->irq, kstat_irqs(cs->irq));
                if (kstat_irqs(cs->irq) == irq_cnt) {
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@xxxxxxxxxxxxxx
http://lists.osdl.org/mailman/listinfo/kernel-janitors
<Prev in Thread] Current Thread [Next in Thread>