logo       

[Kernel-janitors] [PATCH] isdn/hfc_pci: replace schedule_timeout() with msl: msg#00247

Subject: [Kernel-janitors] [PATCH] isdn/hfc_pci: replace schedule_timeout() with msleep()
I would appreciate any comments from the janitors list.

Thanks,
Nish



Applys-to: 2.6.7

Description: Replace schedule_timeout() with msleep() to guarantee the
task delays the desired time.

Signed-off-by: Nishanth Aravamudan <nacc@xxxxxxxxxx>


--- linux-vanilla/drivers/isdn/hisax/hfc_pci.c  2004-06-16 05:19:22.000000000 
+0000
+++ linux-dev/drivers/isdn/hisax/hfc_pci.c      2004-07-02 18:14:28.000000000 
+0000
@@ -1619,8 +1619,7 @@ hfcpci_card_msg(struct IsdnCardState *cs
                        inithfcpci(cs);
                        reset_hfcpci(cs);
                        spin_unlock_irqrestore(&cs->lock, flags);
-                       set_current_state(TASK_UNINTERRUPTIBLE);
-                       schedule_timeout((80 * HZ) / 1000);     /* Timeout 80ms 
*/
+                       msleep(80);                             /* Timeout 80ms 
*/
                        /* now switch timer interrupt off */
                        spin_lock_irqsave(&cs->lock, flags);
                        cs->hw.hfcpci.int_m1 &= ~HFCPCI_INTS_TIMER;
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@xxxxxxxxxxxxxx
http://lists.osdl.org/mailman/listinfo/kernel-janitors
<Prev in Thread] Current Thread [Next in Thread>