logo       

[Kernel-janitors] [PATCH] isdn/elsa: replace schedule_timeout() with msleep: msg#00246

Subject: [Kernel-janitors] [PATCH] isdn/elsa: replace schedule_timeout() with msleep()
I would appreciate any comments from the janitors list.

Thanks,
Nish



Applys-to: 2.6.7

Description: Replace schedule_timeout() with msleep() to guarantee the
task delays the desired time.

Signed-off-by: Nishanth Aravamudan <nacc@xxxxxxxxxx>


--- linux-vanilla/drivers/isdn/hisax/elsa.c     2004-06-16 05:18:59.000000000 
+0000
+++ linux-dev/drivers/isdn/hisax/elsa.c 2004-07-02 18:14:11.000000000 +0000
@@ -691,8 +691,7 @@ Elsa_card_msg(struct IsdnCardState *cs, 
                                byteout(cs->hw.elsa.ctrl, cs->hw.elsa.ctrl_reg);
                                byteout(cs->hw.elsa.timer, 0);
                                spin_unlock_irqrestore(&cs->lock, flags);
-                               set_current_state(TASK_UNINTERRUPTIBLE);
-                               schedule_timeout((110*HZ)/1000);
+                               msleep(110);
                                spin_lock_irqsave(&cs->lock, flags);
                                cs->hw.elsa.ctrl_reg &= ~ELSA_ENA_TIMER_INT;
                                byteout(cs->hw.elsa.ctrl, cs->hw.elsa.ctrl_reg);
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@xxxxxxxxxxxxxx
http://lists.osdl.org/mailman/listinfo/kernel-janitors
<Prev in Thread] Current Thread [Next in Thread>