logo       

Re: [Kernel-janitors] [PATCH] bluetooth/bluecard: replace schedule_timeout(: msg#00224

Subject: Re: [Kernel-janitors] [PATCH] bluetooth/bluecard: replace schedule_timeout() with msleep()
Hi Nish,

> I am really sorry for this, but I didn't change what I had changed
> before in the compileable patch (msleep(10) instead of mlseep(100)).
> This is the final one, I swear (I think).
> 
> Please find below the corrected version, which compiles without error
> for me.
> 
> I would appreciate any comments from the janitors list. This is one (of
> many) cases where I made a decision about replacing
> 
> set_current_state(TASK_INTERRUPTIBLE);
> schedule_timeout(some_time);
> 
> with
> 
> msleep(jiffies_to_msecs(some_time));
> 
> msleep() is not exactly the same as the previous code, but I only did
> this replacement where I thought long delays were *desired*. If this is
> not the case here, then just disregard this patch.

you haven't had to resend the patches. I already applied all of them and
fixed the warning in my tree. And I took the right one for bluecard_cs.

Regards

Marcel


_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@xxxxxxxxxxxxxx
http://lists.osdl.org/mailman/listinfo/kernel-janitors
<Prev in Thread] Current Thread [Next in Thread>