logo       

Re: [Kernel-janitors] [PATCH] ieee/sbp2: replace schedule_timeout() with ms: msg#00220

Subject: Re: [Kernel-janitors] [PATCH] ieee/sbp2: replace schedule_timeout() with msleep()
On Thu, Jul 22, 2004 at 10:35:28PM +0000, Nishanth Aravamudan wrote:
> I would appreciate any comments from the janitors list. This is one (of
> many) cases where I made a decision about replacing
> 
> set_current_state(TASK_INTERRUPTIBLE);
> schedule_timeout(some_time);
> 
> with
> 
> msleep(jiffies_to_msecs(some_time));
> 
> msleep() is not exactly the same as the previous code, but I only did
> this replacement where I thought long delays were *desired*. If this is
> not the case here, then just disregard this patch.

Doesn't msleep() block? If so, that's not what we want at all. We want
other things to happen during that time (like maybe catch a bus reset).

-- 
Debian     - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
Subversion - http://subversion.tigris.org/
WatchGuard - http://www.watchguard.com/
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@xxxxxxxxxxxxxx
http://lists.osdl.org/mailman/listinfo/kernel-janitors
<Prev in Thread] Current Thread [Next in Thread>