[Kernel-janitors] [PATCH] pcwd: replace schedule_timeout() with msleep()

I would appreciate any comments from the janitors list. This is one (of
many) cases where I made a decision about replacing

set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(some_time);

with

msleep(jiffies_to_msecs(some_time));

msleep() is not exactly the same as the previous code, but I only did
this replacement where I thought long delays were *desired*. If this is
not the case here, then just disregard this patch.

Thanks,
Nish



Applys-to: 2.6.7

Description: Uses msleep() instead of schedule_timeout() to guarantee
the task delays at least the desired time amount.

Signed-off-by: Nishanth Aravamudan <nacc@xxxxxxxxxx>


--- linux-vanilla/drivers/char/watchdog/pcwd.c  2004-06-16 05:18:57.000000000 
+0000
+++ linux-dev/drivers/char/watchdog/pcwd.c      2004-07-12 18:06:13.000000000 
+0000
@@ -867,8 +867,7 @@ static int __init pcwd_checkcard(int bas
                /* Not an 'ff' from a floating bus, so must be a card! */
                for (i = 0; i < 4; ++i) {
 
-                       set_current_state(TASK_INTERRUPTIBLE);
-                       schedule_timeout(HZ / 2);
+                       msleep(500);
 
                        last_port0 = port0;
                        last_port1 = port1;

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@xxxxxxxxxxxxxx
http://lists.osdl.org/mailman/listinfo/kernel-janitors