logo       

[Kernel-janitors] [PATCH] nbd: replace schedule_timeout() with msleep(): msg#00201

Subject: [Kernel-janitors] [PATCH] nbd: replace schedule_timeout() with msleep()
Please find below the corrected patch, as the previous one would not
compile. Thanks.

I would appreciate any comments from the janitors list.


Applys-to: 2.6.7

Description: Uses msleep() instead of schedule_timeout() to guarantee
the task delays at least the desired time amount.

Signed-off-by: Nishanth Aravamudan <nacc@xxxxxxxxxx>


--- linux-vanilla/drivers/block/nbd.c   2004-06-16 05:19:01.000000000 +0000
+++ linux-dev/drivers/block/nbd.c       2004-07-21 16:51:48.000000000 +0000
@@ -54,6 +54,7 @@
 #include <linux/errno.h>
 #include <linux/file.h>
 #include <linux/ioctl.h>
+#include <linux/delay.h>
 #include <net/sock.h>
 
 #include <linux/devfs_fs_kernel.h>
@@ -139,8 +140,7 @@ static void nbd_end_request(struct reque
                spin_unlock(&lo->queue_lock);
                printk(KERN_DEBUG "%s: request %p still in use (%d), waiting\n",
                    lo->disk->disk_name, req, req->ref_count);
-               set_current_state(TASK_UNINTERRUPTIBLE);
-               schedule_timeout(HZ); /* wait a second */
+               msleep(1000);
                spin_lock(&lo->queue_lock);
        }
        spin_unlock(&lo->queue_lock);
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@xxxxxxxxxxxxxx
http://lists.osdl.org/mailman/listinfo/kernel-janitors
<Prev in Thread] Current Thread [Next in Thread>