[Kernel-janitors] [PATCH] bluetooth: replace schedule_timeout() with msleep()

Please find below the corrected version, which compiles without error
for me.

I would appreciate any comments from the janitors list. This is one (of
many) cases where I made a decision about replacing

set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(some_time);

with

msleep(jiffies_to_msecs(some_time));

msleep() is not exactly the same as the previous code, but I only did
this replacement where I thought long delays were *desired*. If this is
not the case here, then just disregard this patch.

Thanks,
Nish



Applys-to: 2.6.7

Description: Uses msleep() instead of schedule_timeout() to guarantee
the task delays at least the desired time amount.

Signed-off-by: Nishanth Aravamudan <nacc@xxxxxxxxxx>


--- linux-vanilla/drivers/bluetooth/btuart_cs.c 2004-06-16 05:20:26.000000000 
+0000
+++ linux-dev/drivers/bluetooth/btuart_cs.c     2004-07-21 16:54:09.000000000 
+0000
@@ -32,7 +32,7 @@
 #include <linux/ptrace.h>
 #include <linux/ioport.h>
 #include <linux/spinlock.h>
-
+#include <linux/delay.h>
 #include <linux/skbuff.h>
 #include <linux/string.h>
 #include <linux/serial.h>
@@ -545,8 +545,7 @@ int btuart_open(btuart_info_t *info)
        btuart_change_speed(info, DEFAULT_BAUD_RATE);
 
        /* Timeout before it is safe to send the first HCI packet */
-       set_current_state(TASK_INTERRUPTIBLE);
-       schedule_timeout(HZ);
+       msleep(1000);
 
        /* Register HCI device */
        if (hci_register_dev(hdev) < 0) {

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@xxxxxxxxxxxxxx
http://lists.osdl.org/mailman/listinfo/kernel-janitors