logo       

Re: [Kernel-janitors] kobject_set_name(), return never checked: msg#00222

Subject: Re: [Kernel-janitors] kobject_set_name(), return never checked
On Mon, May 31, 2004 at 12:38:42PM +0200, Walter Harms wrote:
> Hi list,
> i have noticed that the returncode of kobject_set_name() is
> not checked for errors (read: i did not find any who does). therefor i would 
> suggest a wrapper like:
> 
> void kobject_set_name() 
> {
> if (real_kobject_set_name()<0)
>  error_message;
> }
> 
> This will not solve the problem, not checking for error is bad, but
> should work as a quick fix.

No, fix the callers if you really want to, don't mess with the current
interface.

thanks,

greg k-h
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@xxxxxxxxxxxxxx
http://lists.osdl.org/mailman/listinfo/kernel-janitors
<Prev in Thread] Current Thread [Next in Thread>