Subject: [Kernel-janitors] kobject_set_name(), return never checked - msg#00221

Previous Message by Date: click to view message preview

Re: [Kernel-janitors] [announce] kjt2 for 2.6.7-rc1

hi, i send the revisited patches for 2.6.6 directly to you. did something go wrong ? btw: i forgot to add Signed-off-by: walter (wharms@xxxxxx) regards, walter Backlog: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ - check kernel_thread() results (Walter Harms); ping walter which don't apply _______________________________________________ Kernel-janitors mailing list Kernel-janitors@xxxxxxxxxxxxxx http://lists.osdl.org/mailman/listinfo/kernel-janitors

Next Message by Date: click to view message preview

Re: [Kernel-janitors] kobject_set_name(), return never checked

On Mon, May 31, 2004 at 12:38:42PM +0200, Walter Harms wrote: > Hi list, > i have noticed that the returncode of kobject_set_name() is > not checked for errors (read: i did not find any who does). therefor i would > suggest a wrapper like: > > void kobject_set_name() > { > if (real_kobject_set_name()<0) > error_message; > } > > This will not solve the problem, not checking for error is bad, but > should work as a quick fix. No, fix the callers if you really want to, don't mess with the current interface. thanks, greg k-h _______________________________________________ Kernel-janitors mailing list Kernel-janitors@xxxxxxxxxxxxxx http://lists.osdl.org/mailman/listinfo/kernel-janitors

Previous Message by Thread: click to view message preview

Fwd:Valium delivered to your home

  Prozac   Vlagra  Phentermlne  Soma  Amblen Vallum   Clalis  Xanax Get over 300 medicatlons online shlpped overnight to your front door with no prescrlption.    *  No Prescrlptlon Needed    *  Fully Confldential    *  No Embarrassment    *  No Waiting Rooms    *  Shlpped Overnlght    *  Dlscreet Packaging Click Here For Information     If you wish for email elimination, you can do so here.         mix palliate residuary ida balinese footnote lacrosse sadism emmett booty christ concave opine paoli negate ida crafty backdrop martyrdom archival ceramic grandniece circumsphere daydream follicular typeset thirst homonym cavalcade rollins axisymmetric dickey kibitz blest synapse follow fireproof erik craftspeople shrike boyhood yuh lethal six donahue luminous bosonic lettermen complaisant belfry war mantle leadsman trapezoidal giblet accustom eighty abscissae trypsin hendrick counterfeit reign lessor squawroot linotype mantis oakland bunt edwina chicago gent continued daffy glyph palsy contain multi cavalcade arboreal telepathy bujumbura nightgown deducible alabamian interest congolese grind hideaway delano commandcoffman rutland jubilee tapa eutectic nh procrustean betrothal telephony stimulate ashmolean cryptanalysis elephantine comparative calumniate dimension sea curium tying chard miasma candlestick tinge deject directorial tideland determinate consonant spellbound orgiastic lombardy contrite chartres crease hark bowstring alberta chock strophe leucine cellular cleveland tradeoff inapplicable curt distort diagonal archipelago elliot infinitude circa freer prevent halo abdominal asilomar bias paragonite chow oliver zaire marital propose carbondale adequacy fortran chanson food real muir

Next Message by Thread: click to view message preview

Re: [Kernel-janitors] kobject_set_name(), return never checked

On Mon, May 31, 2004 at 12:38:42PM +0200, Walter Harms wrote: > Hi list, > i have noticed that the returncode of kobject_set_name() is > not checked for errors (read: i did not find any who does). therefor i would > suggest a wrapper like: > > void kobject_set_name() > { > if (real_kobject_set_name()<0) > error_message; > } > > This will not solve the problem, not checking for error is bad, but > should work as a quick fix. No, fix the callers if you really want to, don't mess with the current interface. thanks, greg k-h _______________________________________________ Kernel-janitors mailing list Kernel-janitors@xxxxxxxxxxxxxx http://lists.osdl.org/mailman/listinfo/kernel-janitors