logo       

Re: [Kernel-janitors] [PATCH] kernel_thread() audit drivers/scsi/aacraid/rk: msg#00215

Subject: Re: [Kernel-janitors] [PATCH] kernel_thread() audit drivers/scsi/aacraid/rkt.c (2.6.7-rc1) (forgot signing-off)
On Fri, 28 May 2004 22:40:34 -0600 (MDT) MJK <mkemp@xxxxxxxxxxx> wrote:

| 
| 
|       Compiles fine, took Randy's advice.
| 
|       Signed-off-by: MJK <mkemp@xxxxxxxxxxx>
| 
| Sweet cuppin-cakes!
| M. Kemp

Hi,

Those all look good to me.

Now what it needs (IMO of course, but this comes from sending lots
of patches to Andrew and getting feedback on them) is a more
descriptive subject: line and description (in the email body)
of what/why the patch is/does.  Otherwise the patchset maintainer
will have to generate all of that when the patch is forwarded,
and s/he shouldn't have to do that extra bit.

--
~Randy
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@xxxxxxxxxxxxxx
http://lists.osdl.org/mailman/listinfo/kernel-janitors
<Prev in Thread] Current Thread [Next in Thread>