[Kernel-janitors] [PATCH] kernel_thread() audit drivers/scsi/aacraid/rx.c (2.6.7-rc1)

        Took suggestions (Thanks Randy, Mark!). I also noticed that else
where in aac_rx_init() there are error returns but no iounmapping. Should
I also fix that behavior?

        Signed-off-by: MJK <mkemp@xxxxxxxxxxx>

Cordially,
M. Kemp

--- old.linux-2.6.7-rc1/drivers/scsi/aacraid/rx.c       2004-05-09 
20:33:22.000000000 -0600
+++ new.linux-2.6.7-rc1/drivers/scsi/aacraid/rx.c       2004-05-27 
21:42:40.283536451 -0600
@@ -435,6 +435,13 @@
         *      Start any kernel threads needed
         */
        dev->thread_pid = kernel_thread((int (*)(void *))aac_command_thread, 
dev, 0);
+       if (dev->thread_pid < 0) {
+               printk(KERN_ERR "aacraid: unable to create i960 command 
thread.\n");
+               free_irq(dev->scsi_host_ptr->irq, (void *)dev);
+               kfree(dev->queues);
+               iounmap(dev->regs.rx);
+               return -1;
+       }
        /*
         *      Tell the adapter that all is configured, and it can start
         *      accepting requests

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@xxxxxxxxxxxxxx
http://lists.osdl.org/mailman/listinfo/kernel-janitors