logo       

[Kernel-janitors] Re: Replaces yield() with nicedelay() on drivers/net/sb10: msg#00176

Subject: [Kernel-janitors] Re: Replaces yield() with nicedelay() on drivers/net/sb1000.c.
On 24/05/04 21:49 -0300, Gustavo Franco wrote:
> Domen Puncer wrote:
> >On 02/05/04 22:24 -0300, Gustavo Franco wrote:
> >
> >>Hi,
> >>
> >>It's the last REDIFF, but i'm not replacing yield() with 
> >>schedule_timeout() because there's a nicedelay() (maybe the
> >>usecs need to be tuned below) there:
> >>
> >>
> >>static inline void nicedelay(unsigned long usecs)
> >>{
> >>       current->state = TASK_INTERRUPTIBLE;
> >>       schedule_timeout(HZ);
> >>       return;
> >>}
> >
> >
> >And usecs stands for??
> >Funny thing is that there are actualy uses of this function.
> 
> What do you think about msleep() as greg said?

msleep is definitely the way to go, it includes set_current_state, and
is more readable.

> >Also, please make -p1 applyable patches.
> 
> I'm preparing my travel to debconf4, i'll be back on 30 May.In
> early June i'll send rediffied patches.As i said in a previous
> post it was my error.I was still considering the "old" SubmittingPatches.
> 
> 
> Thanks,
> Gustavo Franco

> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@xxxxxxxxxxxxxx
> http://lists.osdl.org/mailman/listinfo/kernel-janitors

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@xxxxxxxxxxxxxx
http://lists.osdl.org/mailman/listinfo/kernel-janitors
<Prev in Thread] Current Thread [Next in Thread>