logo       

Re: [Kernel-janitors] Re: Replaces yield() with nicedelay() on drivers/net/: msg#00172

Subject: Re: [Kernel-janitors] Re: Replaces yield() with nicedelay() on drivers/net/sb1000.c.
Greg KH wrote:
On Mon, May 24, 2004 at 03:24:40PM +0200, Domen Puncer wrote:

On 02/05/04 22:24 -0300, Gustavo Franco wrote:

Hi,

It's the last REDIFF, but i'm not replacing yield() with schedule_timeout() because there's a nicedelay() (maybe the
usecs need to be tuned below) there:


static inline void nicedelay(unsigned long usecs)
{
       current->state = TASK_INTERRUPTIBLE;
       schedule_timeout(HZ);
       return;
}

And usecs stands for??
Funny thing is that there are actualy uses of this function.

Yes, it's not my piece of code.

Heh, also look at using the msleep function instead of redefining your
own function.


Are you recommending to use msleep() instead schedule_timeout() to replace yield() ? Only in some cases? What?


Thanks,
Gustavo Franco
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@xxxxxxxxxxxxxx
http://lists.osdl.org/mailman/listinfo/kernel-janitors
<Prev in Thread] Current Thread [Next in Thread>