On 22/05/04 18:54 -0300, Gustavo Franco wrote:
> Hi list,
>
> [Patch aplied against 2.6.6-bk9 - compiles cleanly. ]
>
> I've added two error checks for request_region() calls on the source
> and replaced a check_region() with request_region().The release_region()
> calls seems to be ok, but let me known if i'm missing something.
>
> Comments?
>
You request same region twice...
> +++ sound/oss/wavfront.c 2004-05-22 18:28:38.000000000 -0300
> + if (!request_region (io_base, 16, "wavefront")) {
Few lines later there is a:
dev.base = io_base;
So this will print ugly error messages.
> + if(!request_region (dev.base+2, 6, "wavefront synth")) {
> + if(!request_region (dev.base+8, 8, "wavefront fx")) {
IMHO, you can just get rid of latter 2 request_region's.
And don't forget about release_region.
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@xxxxxxxxxxxxxx
http://lists.osdl.org/mailman/listinfo/kernel-janitors
|
