Hello,
I'm doing some research work on VFS and linux filesystems.
I used kernel 2.4.25 but this things hold true for 2.6 as well
1)
I found some unused old functions and structures in fs/readdir.c
old unused functions: old_readdir, fillonedir and
old unusedstructures: old_linux_dirent, readdir_callback
they aren't reffered anywhere in the kernel,
maybe they should be removed?
2)
in function dcache_readdir why we need the variable "i" ?
the call to filldir doesn't change it,
so why don't use filp->f_pos ?
(for kernel 2.6 dcache_reddir is in fs/libfs.c now..)
BTW, shouldn't MAINTAINERS in kernel 2.4 contain a refference for VFS
maintainer?
If I send this email to the wrong place, please direct me the right place to
send it.
Thank you,
--adrian.
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@xxxxxxxxxxxxxx
http://lists.osdl.org/mailman/listinfo/kernel-janitors
|
