On Saturday 29 of November 2003 16:33, Ron Gage wrote:
> Christoph:
>
> This patch removes the check_region call from skfddi.c and replaces it with
> request_region. It also adds a release_region call at module unload time.
First:
Adding yourself to file for such trivial change will make kernel bloated (just
count all the check_region and similar depredated stuff... how many entries
does that make?).
Second:
Patch is wrong
check_region returns !=0 when fails, request_region returns 0 on failure.
Also, you missed already existing request_region and release_region.
Domen
> Reason: check_reason is deprecated from the 2.6 kernel.
>
> Timing: This patch is intended to be applied after the kernel freeze is
> lifted.
>
> Thanks.
|
