i thing this should (also) go into 2.4.x as well bad style is bad style.
the point is to convince the maintainers. But after this incident
they will be willing to accept changes that improve readability.
(perhaps: somebody can talk to linus to make a statement to remove
that kind of code)
The first step would to create a tools that find statemenst like
if ( (A=b)<0 ). I have played with a grep pipeline and found only
a few lines of code. perhaps somebody can make a tool that will show
automaticly such kind of code.
walter
> of cause this will not solve the problem but help to reduce complexity of
> finding current->uid=0 (and friends). It may
> even uncover hidden bugs. ( i dont like if (ret=foo())<0) and friends).
>
> any comments ?
I don't like as well, and as much as I can I remove such things in my code and
in other areas that I send patches, but I don't think Linus is willing to accept
such patches at this time, perhaps in 2.7.
- Arnaldo
-------------------------------------------------------
This SF.Net email sponsored by: ApacheCon 2003,
16-19 November in Las Vegas. Learn firsthand the latest
developments in Apache, PHP, Perl, XML, Java, MySQL,
WebDAV, and more! http://www.apachecon.com/
|
