Subject: playground/utils/workflow/src - msg#10551

List: kde-commits

Date: Prev Next Index Thread: Prev Next Index

SVN commit 1029868 by dfaure:

It finally compiles!
Had to rename widgets/ to workflow/ since that's how the generated file
includes the headers (e.g. <workflow/combobox.h>).

M +5 -5 commands/CMakeLists.txt
M +0 -5 commands/file/CMakeLists.txt
M +1 -1 commands/file/copyfilescommand.cpp
M +1 -1 commands/file/listfoldercontentscommand.cpp
M +2 -2 commands/file/movefilescommand.cpp
M +1 -1 commands/foreachcommand.cpp
M +0 -5 commands/image/CMakeLists.txt
M +1 -1 commands/image/flipimagecommand.cpp
M +1 -1 commands/image/rotateimagecommand.cpp
M +1 -1 commands/image/scaleimagecommand.cpp
M +2 -2 commands/loadfromvariablecommand.cpp
M +4 -4 commands/sortlistcommand.cpp
M +0 -5 commands/text/CMakeLists.txt
M +1 -1 commands/text/readtextfilescommand.cpp
M +2 -2 commands/variablemodel.cpp
M +2 -2 sdk/debugger/CMakeLists.txt
M +4 -4 sdk/debugger/mainwindow.cpp
M +2 -2 sdk/debugger/parameterinspector.cpp
M +2 -2 sdk/debugger/resultinspector.cpp
M +2 -2 sdk/designer/CMakeLists.txt
M +2 -2 sdk/designer/commanddialog.cpp
M +8 -8 sdk/designer/commandruntimedialog.cpp
M +3 -3 sdk/designer/datatypedialog.cpp
M +2 -2 sdk/designer/iowidget.cpp
M +5 -5 sdk/designer/librarywidget.cpp
M +1 -1 sdk/designer/parameterdialog.cpp
M +2 -2 sdk/designer/resultdialog.cpp
M +1 -1 sdk/designer/selecttypedialog.cpp
M +2 -2 ui/CMakeLists.txt
M +1 -1 ui/plugin/CMakeLists.txt
D ui/widgets (directory)
AM ui/workflow (directory) ui/widgets#1029701
A ui/workflow/imageviewer.cpp ui/widgets/imageviewer.cpp#1029855
[License: GPL (v2+)]

http://websvn.kde.org/?view=rev&revision=1029868

Was this page helpful?

Thread at a glance:

Previous Message by Date: click to view message preview

KDE/kdepim/akonadi/akonadiconsole

SVN commit 1029867 by pokrzywka: another missing include M +1 -0 akonadibrowsermodel.h --- trunk/KDE/kdepim/akonadi/akonadiconsole/akonadibrowsermodel.h #1029866:1029867 @@ -21,6 +21,7 @@ #define AKONADIBROWSERMODEL_H #include <akonadi/entitytreemodel.h> +#include <akonadi/changerecorder.h> using namespace Akonadi;

Next Message by Date: click to view message preview

playground/utils

SVN commit 1029869 by dfaure: strict iterators fixes (prevents unwanted detaching) M +1 -1 filelight/src/part/remoteLister.cpp M +2 -2 kconfigeditor/src/kconfigeditorsearchline.cpp M +2 -2 kconfigeditor/src/propertyeditor/multiproperty.cpp M +2 -2 kconfigeditor/src/propertyeditor/pcombobox.cpp M +2 -2 kconfigeditor/src/propertyeditor/propertylist.cpp --- trunk/playground/utils/filelight/src/part/remoteLister.cpp #1029868:1029869 @@ -128,7 +128,7 @@ { //m_directory is set to the directory we should operate on - KFileItemList items = KDirLister::items(); + const KFileItemList items = KDirLister::items(); for (KFileItemList::ConstIterator it = items.begin(), end = items.end(); it != end; ++it) { if (it->isDir()) --- trunk/playground/utils/kconfigeditor/src/kconfigeditorsearchline.cpp #1029868:1029869 @@ -188,8 +188,8 @@ // specifified. If it is empty default to searching all of the columns. if (!d->searchColumns.isEmpty()) { - QList<int>::ConstIterator it = d->searchColumns.begin(); - for (; it != d->searchColumns.end(); ++it) { + QList<int>::ConstIterator it = d->searchColumns.constBegin(); + for (; it != d->searchColumns.constEnd(); ++it) { if (*it < item->listView()->columns() && item->text(*it).indexOf(s, 0, d->caseSensitive) >= 0) return true; --- trunk/playground/utils/kconfigeditor/src/propertyeditor/multiproperty.cpp #1029868:1029869 @@ -223,7 +223,7 @@ if (type() != Property::ValueFromList) return val; QMap<QString, QVariant> vl = valueList(); - for (QMap<QString, QVariant>::const_iterator it = vl.begin(); it != vl.end(); ++ it) { + for (QMap<QString, QVariant>::const_iterator it = vl.constBegin(); it != vl.constEnd(); ++ it) { if (*it == val) return it.key(); } @@ -235,7 +235,7 @@ if (type() != Property::ValueFromList) return val; QMap<QString, QVariant> vl = valueList(); - for (QMap<QString, QVariant>::const_iterator it = vl.begin(); it != vl.end(); ++ it) { + for (QMap<QString, QVariant>::const_iterator it = vl.constBegin(); it != vl.constEnd(); ++ it) { if (*it == val) return it.key(); } --- trunk/playground/utils/kconfigeditor/src/propertyeditor/pcombobox.cpp #1029868:1029869 @@ -55,7 +55,7 @@ void PComboBox::fillBox() { - for (QMap<QString, QVariant>::const_iterator it = m_valueList.begin(); it != m_valueList.end(); it++) { + for (QMap<QString, QVariant>::const_iterator it = m_valueList.constBegin(); it != m_valueList.constEnd(); it++) { m_edit->addItem(it.key()); } } @@ -86,7 +86,7 @@ QString PComboBox::findDescription(const QVariant &value) { - for (QMap<QString, QVariant>::const_iterator it = m_valueList.begin(); it != m_valueList.end(); ++ it) { + for (QMap<QString, QVariant>::const_iterator it = m_valueList.constBegin(); it != m_valueList.constEnd(); ++ it) { if (*it == value) return it.key(); } --- trunk/playground/utils/kconfigeditor/src/propertyeditor/propertylist.cpp #1029868:1029869 @@ -215,8 +215,8 @@ : PropertyList(false) { //deep copy of m_list - for (QMap<QString, MultiProperty*>::const_iterator it = list->m_list.begin(); - it != list->m_list.end(); ++it) { + for (QMap<QString, MultiProperty*>::const_iterator it = list->m_list.constBegin(); + it != list->m_list.constEnd(); ++it) { MultiProperty *mp = new MultiProperty(*(it.value())); mp->m_propertyList = this; addToGroup(list->m_groupOfProperty[*it], mp);

Previous Message by Thread: click to view message preview

playground/utils/workflow/src

SVN commit 1029855 by dfaure: Fix compilation with strict iterators, part 2 M +1 -1 commands/image/convertimagecommand.cpp M +2 -2 ui/commandport.cpp M +2 -2 ui/helpwidget.cpp M +1 -1 ui/selectworkflowdialog.cpp M +5 -5 ui/view.cpp M +3 -3 ui/widgets/imageviewer.cpp --- trunk/playground/utils/workflow/src/commands/image/convertimagecommand.cpp #1029854:1029855 @@ -51,7 +51,7 @@ int count = files.count(); int num = 1; - for (QStringList::ConstIterator i = files.begin(); i != files.end(); ++i, ++num) { + for (QStringList::ConstIterator i = files.constBegin(); i != files.constEnd(); ++i, ++num) { KProcess proc; proc << "convert"; KUrl url(*i); --- trunk/playground/utils/workflow/src/ui/commandport.cpp #1029854:1029855 @@ -83,7 +83,7 @@ if (params.count() <= 1) return; - for (Command::ParameterList::ConstIterator it = params.begin(); it != params.end(); ++it) { + for (Command::ParameterList::ConstIterator it = params.constBegin(); it != params.constEnd(); ++it) { menu.addAction(new SlotAction(&menu, *it)); } } else { @@ -91,7 +91,7 @@ if (results.count() <= 1) return; - for (Command::ResultList::ConstIterator it = results.begin(); it != results.end(); ++it) { + for (Command::ResultList::ConstIterator it = results.constBegin(); it != results.constEnd(); ++it) { menu.addAction(new SlotAction(&menu, *it)); } } --- trunk/playground/utils/workflow/src/ui/helpwidget.cpp #1029854:1029855 @@ -73,13 +73,13 @@ typedef CommandDescription::ResultDescList Results; Params params = desc->parameters(); - for (Params::ConstIterator i = params.begin(); i != params.end(); ++i) { + for (Params::ConstIterator i = params.constBegin(); i != params.constEnd(); ++i) { if (!(*i)->description().isEmpty()) paramlist += slottemplate.arg((*i)->name(), (*i)->description()); } Results results = desc->results(); - for (Results::ConstIterator i = results.begin(); i != results.end(); ++i) { + for (Results::ConstIterator i = results.constBegin(); i != results.constEnd(); ++i) { if (!(*i)->description().isEmpty()) resultlist += slottemplate.arg((*i)->name(), (*i)->description()); } --- trunk/playground/utils/workflow/src/ui/selectworkflowdialog.cpp #1029854:1029855 @@ -50,7 +50,7 @@ : FileListModel(parent) { KStandardDirs stdDirs; - QStringList dirs = stdDirs.findDirs("data", "workflow/apps/" + appid); + const QStringList dirs = stdDirs.findDirs("data", "workflow/apps/" + appid); for (QStringList::ConstIterator i = dirs.begin(); i != dirs.end(); ++i) { QDir dir(*i, "*.workflow"); --- trunk/playground/utils/workflow/src/ui/view.cpp #1029854:1029855 @@ -209,7 +209,7 @@ if (!cell) return false; - for (AreaList::ConstIterator i = cellAreas.begin(); i != cellAreas.end(); ++i) { + for (AreaList::ConstIterator i = cellAreas.constBegin(); i != cellAreas.constEnd(); ++i) { if ((*i).rect().contains(position)) { *cell = *i; return true; @@ -224,7 +224,7 @@ if (!cell) return false; - for (AreaList::ConstIterator i = cellAreas.begin(); i != cellAreas.end(); ++i) { + for (AreaList::ConstIterator i = cellAreas.constBegin(); i != cellAreas.constEnd(); ++i) { if ((*i).row() == row) { *cell = *i; return true; @@ -327,7 +327,7 @@ void View::Private::slotSelectionChanged(CommandWidget* /*widget*/) { - + } // View implementation @@ -646,7 +646,7 @@ p->setPen(Qt::blue); p->setBrush(Qt::blue); - for (AreaList::ConstIterator i = d->cellAreas.begin(); i != d->cellAreas.end(); ++i) { + for (AreaList::ConstIterator i = d->cellAreas.constBegin(); i != d->cellAreas.constEnd(); ++i) { CommandWidget* w = d->commandWidget((*i).row()); if (w && w->isSelected()) { p->drawRect((*i).rect()); @@ -816,7 +816,7 @@ swap(start, end); } - for (AreaList::ConstIterator i = d->cellAreas.begin(); i != d->cellAreas.end(); ++i) { + for (AreaList::ConstIterator i = d->cellAreas.constBegin(); i != d->cellAreas.constEnd(); ++i) { if (!inside && start.isEqualTo((*i).row())) { inside = true; } --- trunk/playground/utils/workflow/src/ui/widgets/imageviewer.cpp #1029854:1029855 @@ -156,10 +156,10 @@ // p->scale(d->zoom, d->zoom); // QMatrix invscale; // invscale.scale(1.0/d->zoom, 1.0/d->zoom); -// +// // QRect exposedRect = invscale.mapRect(QRect(cx, cy, cw, ch)); // exposedRect.adjust(-1, -1, 1, 1); -// +// // p->drawPixmap(QPoint(exposedRect.x(), exposedRect.y()), d->pixmap, exposedRect); QPainter p(this); @@ -247,7 +247,7 @@ { KUrl::List urls = KUrl::List::fromMimeData(e->mimeData()); if (!urls.isEmpty()) { - for (KUrl::List::ConstIterator i = urls.begin(); i != urls.end(); ++i) { + for (KUrl::List::ConstIterator i = urls.constBegin(); i != urls.constEnd(); ++i) { QString path = (*i).path(); if (!d->autoLoad || (d->autoLoad && setImage(path))) { emit dropped(path);

Next Message by Thread: click to view message preview

koffice/kexi/formeditor

SVN commit 1029856 by dfaure: port from deprecated remove(T) M +1 -1 events.cpp --- trunk/koffice/kexi/formeditor/events.cpp #1029855:1029856 @@ -136,7 +136,7 @@ } } foreach (Connection *c, toRemove) { - remove(c); + removeAll(c); } qDeleteAll(toRemove); }

Loading Comments...