|
java/text/SimpleDateFormat.java (compileFormat): msg#00177java.vm.kaffe.general
Hi, Browsing GNU Classpath's CVS log, I found: 2003-10-02 Michael Koch <konqueror@xxxxxx> * java/text/SimpleDateFormat.java (compileFormat): Character.isLetter(char) allows too much characters. Replace it with Character.isLowerCase(char) || Character.isUpperCase(char). I think this change has something to do with the bug report: http://www.kaffe.org/pipermail/kaffe/2003-August/043742.html http://www.kaffe.org/pipermail/kaffe/2003-August/043743.html, where I suggested to use (thisChar >= 'A' && thisChar <= 'Z') || (thisChar >= 'a' && thisChar <= 'z') instead of Character.isLetter(thisChar) Why do we use "Character.isLowerCase(char) || Character.isUpperCase(char)" when the API doc clearly says, "Within date and time pattern strings, unquoted letters from 'A' to 'Z' and from 'a' to 'z' are interpreted as pattern letters representing the components of a date or time string"? I am afraid "Character.isLowerCase(char) || Character.isUpperCase(char)" also allows too many characters, including Greek or Slavic alphabet or even Japanese Zenkaku alphabet.
|
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| Previous by Date: | Re: GregorianCalendar fixes, Ito Kazumitsu |
|---|---|
| Next by Date: | Re: Re: error:Switch label must be constant [JLS 14.10], Ito Kazumitsu |
| Previous by Thread: | CVS kaffe (kaz): libraries/javalib/java/net/URI.java, Kaffe CVS |
| Next by Thread: | Re: java/text/SimpleDateFormat.java (compileFormat), Michael Koch |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
| News | FAQ | advertise |