On Wed, Mar 22, 2006 at 08:12:08AM +0000, Matthias Radestock wrote:
>
> Scott,
>
> I have reviewed the changes on the 1.13 branch for distinguishing
> between pure functional and other primitives. The changes mostly look
> fine, with a few exceptions:
>
> 1) procedures that should be declared as "simple" instead of "complex"
>
> compact-string-rep
The version that sets as well? I believe I made that one complex
for the one arg case.
>
> 2) procedures that should be declared as "complex" instead of "simple"
>
> set-box!
> set-car!
> set-cdr!
> _signal-hook!
> _signal-unhook!
Yeah, those are obvious. Don't know why I missed them.
> 3) other problems
>
> - there is a bug in thread/holds-lock? which has been there all along:
> it doesn't use its second argument. (This deserves an SF bug).
>
> - I think these fragments in Primitives.java can be removed:
> case DIV:
> case NEQ:
> case LT:
> case GRT:
> case SUB: throwArgSizeException(); return VOID;
>
> case LT:
> case GRT:
> case NEQ: throwArgSizeException(); return VOID;
>
> - it looks like you kept all procedures in *IO as ordinary prims, which
> I think means they are considered impure. That's fine, but we could be
> more selective.
I'll take care of these today.
>
> - did you really mean to add NativeModuleTemplate?
Yes. Its not used by any code, but its still a useful starting point
for library creation. It may want to live elsewhere though, such as
the docs folder.
Scott
>
>
> Matthias
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by xPML, a groundbreaking scripting language
> that extends applications into web and mobile media. Attend the live webcast
> and join the prime developer group breaking into this new coding territory!
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
> _______________________________________________
> SISC-devel mailing list
> SISC-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.sourceforge.net/lists/listinfo/sisc-devel
>
--
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
|
