roller/src/org/roller/business/hibernate BookmarkManagerImpl.java,1.9,1.10 HibernateStrategy.java,1.2,1.3 NewsfeedManagerImpl.java,1.10,1.11 RefererManagerImpl.java,1.26,1.27 RollerImpl.java,1.13,1.14 UserManagerImpl.java,1.21,1.22 WeblogManagerImpl.java,1.27,1.28

Update of /cvsroot/roller/roller/src/org/roller/business/hibernate
In directory sc8-pr-cvs1:/tmp/cvs-serv5432/src/org/roller/business/hibernate

Modified Files:
        BookmarkManagerImpl.java HibernateStrategy.java 
        NewsfeedManagerImpl.java RefererManagerImpl.java 
        RollerImpl.java UserManagerImpl.java WeblogManagerImpl.java 
Log Message:
Cleanups as recommended by Eclipse and PMD.

Index: BookmarkManagerImpl.java
===================================================================
RCS file: 
/cvsroot/roller/roller/src/org/roller/business/hibernate/BookmarkManagerImpl.java,v
retrieving revision 1.9
retrieving revision 1.10
diff -C2 -d -r1.9 -r1.10
*** BookmarkManagerImpl.java    20 Aug 2003 16:37:30 -0000      1.9
--- BookmarkManagerImpl.java    3 Sep 2003 21:21:13 -0000       1.10
***************
*** 4,16 ****
  package org.roller.business.hibernate;
  
- import java.io.Serializable;
- import java.util.List;
- 
  import net.sf.hibernate.Hibernate;
- import net.sf.hibernate.SessionFactory;
  import net.sf.hibernate.type.Type;
  
- import org.apache.commons.logging.Log;
- import org.apache.commons.logging.LogFactory;
  import org.roller.RollerException;
  import org.roller.business.BookmarkManagerBase;
--- 4,10 ----
***************
*** 20,23 ****
--- 14,20 ----
  import org.roller.pojos.FolderData;
  
+ import java.io.Serializable;
+ import java.util.List;
+ 
  /**
   * @author David M Johnson
***************
*** 26,34 ****
      implements BookmarkManager, Serializable
  {
-     private static Log mLogger = 
-         LogFactory.getFactory().getInstance(BookmarkManagerImpl.class);
-     
-     private SessionFactory mSessionFactory; 
- 
      //---------------------------------------------------- Startup and 
Shutdown
  
--- 23,26 ----
***************
*** 43,49 ****
      public FolderData getTopLevelFolder( String userName )
          throws RollerException
!     {
!         String msg = "Getting top folder";
!         
          if ( userName==null )
              throw new RollerException("Username is null");
--- 35,39 ----
      public FolderData getTopLevelFolder( String userName )
          throws RollerException
!     {        
          if ( userName==null )
              throw new RollerException("Username is null");

Index: HibernateStrategy.java
===================================================================
RCS file: 
/cvsroot/roller/roller/src/org/roller/business/hibernate/HibernateStrategy.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -C2 -d -r1.2 -r1.3
*** HibernateStrategy.java      20 Aug 2003 16:37:30 -0000      1.2
--- HibernateStrategy.java      3 Sep 2003 21:21:13 -0000       1.3
***************
*** 4,9 ****
  package org.roller.business.hibernate;
  
- import java.util.List;
- 
  import net.sf.hibernate.HibernateException;
  import net.sf.hibernate.ObjectNotFoundException;
--- 4,7 ----
***************
*** 17,20 ****
--- 15,20 ----
  import org.roller.model.PersistenceStrategy;
  import org.roller.pojos.PersistentObject;
+ 
+ import java.util.List;
  
  

Index: NewsfeedManagerImpl.java
===================================================================
RCS file: 
/cvsroot/roller/roller/src/org/roller/business/hibernate/NewsfeedManagerImpl.java,v
retrieving revision 1.10
retrieving revision 1.11
diff -C2 -d -r1.10 -r1.11
*** NewsfeedManagerImpl.java    20 Aug 2003 16:37:30 -0000      1.10
--- NewsfeedManagerImpl.java    3 Sep 2003 21:21:13 -0000       1.11
***************
*** 4,11 ****
  package org.roller.business.hibernate;
  
- import java.io.Serializable;
- 
- import org.apache.commons.logging.Log;
- import org.apache.commons.logging.LogFactory;
  import org.roller.RollerException;
  import org.roller.business.NewsfeedManagerBase;
--- 4,7 ----
***************
*** 13,16 ****
--- 9,14 ----
  import org.roller.model.PersistenceStrategy;
  
+ import java.io.Serializable;
+ 
  /**
   * @author David M Johnson
***************
*** 19,25 ****
        implements NewsfeedManager, Serializable
  {
-     private static Log mLogger = 
-         LogFactory.getFactory().getInstance(NewsfeedManagerImpl.class);
-     
      public NewsfeedManagerImpl(PersistenceStrategy support) throws 
RollerException
      {
--- 17,20 ----

Index: RefererManagerImpl.java
===================================================================
RCS file: 
/cvsroot/roller/roller/src/org/roller/business/hibernate/RefererManagerImpl.java,v
retrieving revision 1.26
retrieving revision 1.27
diff -C2 -d -r1.26 -r1.27
*** RefererManagerImpl.java     20 Aug 2003 16:37:30 -0000      1.26
--- RefererManagerImpl.java     3 Sep 2003 21:21:13 -0000       1.27
***************
*** 4,17 ****
  package org.roller.business.hibernate;
  
- import java.io.Serializable;
- import java.sql.Connection;
- import java.sql.ResultSet;
- import java.sql.Statement;
- import java.text.SimpleDateFormat;
- import java.util.ArrayList;
- import java.util.Date;
- import java.util.Iterator;
- import java.util.List;
- 
  import net.sf.hibernate.Hibernate;
  import net.sf.hibernate.Session;
--- 4,7 ----
***************
*** 26,29 ****
--- 16,29 ----
  import org.roller.pojos.RefererData;
  import org.roller.pojos.WebsiteDisplayData;
+ 
+ import java.io.Serializable;
+ import java.sql.Connection;
+ import java.sql.ResultSet;
+ import java.sql.Statement;
+ import java.text.SimpleDateFormat;
+ import java.util.ArrayList;
+ import java.util.Date;
+ import java.util.Iterator;
+ import java.util.List;
  
  

Index: RollerImpl.java
===================================================================
RCS file: 
/cvsroot/roller/roller/src/org/roller/business/hibernate/RollerImpl.java,v
retrieving revision 1.13
retrieving revision 1.14
diff -C2 -d -r1.13 -r1.14
*** RollerImpl.java     14 Aug 2003 21:09:49 -0000      1.13
--- RollerImpl.java     3 Sep 2003 21:21:13 -0000       1.14
***************
*** 4,11 ****
  package org.roller.business.hibernate;
  
- import java.io.Serializable;
- 
- import javax.servlet.ServletContext;
- 
  import net.sf.hibernate.HibernateException;
  import net.sf.hibernate.SessionFactory;
--- 4,7 ----
***************
*** 21,24 ****
--- 17,24 ----
  import org.roller.model.UserManager;
  import org.roller.model.WeblogManager;
+ 
+ import java.io.Serializable;
+ 
+ import javax.servlet.ServletContext;
  
  /**

Index: UserManagerImpl.java
===================================================================
RCS file: 
/cvsroot/roller/roller/src/org/roller/business/hibernate/UserManagerImpl.java,v
retrieving revision 1.21
retrieving revision 1.22
diff -C2 -d -r1.21 -r1.22
*** UserManagerImpl.java        20 Aug 2003 16:37:30 -0000      1.21
--- UserManagerImpl.java        3 Sep 2003 21:21:13 -0000       1.22
***************
*** 4,11 ****
  package org.roller.business.hibernate;
  
- import java.io.Serializable;
- 
- import org.apache.commons.logging.Log;
- import org.apache.commons.logging.LogFactory;
  import org.roller.RollerException;
  import org.roller.business.UserManagerBase;
--- 4,7 ----
***************
*** 14,17 ****
--- 10,15 ----
  import org.roller.pojos.PageData;
  
+ import java.io.Serializable;
+ 
  /**
   * Hibernate implemenation of Roller UserManager.
***************
*** 21,27 ****
        implements UserManager, Serializable
  {
-     private static Log mLogger = 
-         LogFactory.getFactory().getInstance(UserManagerImpl.class);
-     
      public UserManagerImpl( RollerImpl roller, PersistenceStrategy support) 
throws RollerException
        {
--- 19,22 ----

Index: WeblogManagerImpl.java
===================================================================
RCS file: 
/cvsroot/roller/roller/src/org/roller/business/hibernate/WeblogManagerImpl.java,v
retrieving revision 1.27
retrieving revision 1.28
diff -C2 -d -r1.27 -r1.28
*** WeblogManagerImpl.java      22 Aug 2003 04:24:39 -0000      1.27
--- WeblogManagerImpl.java      3 Sep 2003 21:21:13 -0000       1.28
***************
*** 4,13 ****
  package org.roller.business.hibernate;
  
- import java.io.Serializable;
- import java.util.ArrayList;
- import java.util.Date;
- import java.util.Iterator;
- import java.util.List;
- 
  import net.sf.hibernate.Hibernate;
  import net.sf.hibernate.type.Type;
--- 4,7 ----
***************
*** 21,24 ****
--- 15,24 ----
  import org.roller.util.DateUtil;
  
+ import java.io.Serializable;
+ import java.util.ArrayList;
+ import java.util.Date;
+ import java.util.Iterator;
+ import java.util.List;
+ 
  /**
   * @author David M Johnson
***************
*** 158,162 ****
  
          query += " where p.publishEntry = ?";
!         argsList.add( new Boolean(true) );
          typesList.add( Hibernate.BOOLEAN );
          
--- 158,162 ----
  
          query += " where p.publishEntry = ?";
!         argsList.add( Boolean.TRUE );
          typesList.add( Hibernate.BOOLEAN );
          




-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf