Update of /cvsroot/roller/roller/src/org/roller/presentation/tags/menu
In directory
usw-pr-cvs1:/tmp/cvs-serv28452/src/org/roller/presentation/tags/menu
Modified Files:
MenuItemImpl.java MenuImpl.java RollerMenuModel.java
Log Message:
Minimizing the number of places that getSession is called
Index: MenuItemImpl.java
===================================================================
RCS file:
/cvsroot/roller/roller/src/org/roller/presentation/tags/menu/MenuItemImpl.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -C2 -d -r1.5 -r1.6
*** MenuItemImpl.java 9 Jun 2002 03:06:11 -0000 1.5
--- MenuItemImpl.java 12 Nov 2002 02:41:42 -0000 1.6
***************
*** 119,123 ****
boolean selected = false;
! HttpSession ses = req.getSession();
ServletContext ctx = ses.getServletContext();
--- 119,123 ----
boolean selected = false;
! HttpSession ses = req.getSession(true);
ServletContext ctx = ses.getServletContext();
Index: MenuImpl.java
===================================================================
RCS file:
/cvsroot/roller/roller/src/org/roller/presentation/tags/menu/MenuImpl.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -C2 -d -r1.2 -r1.3
*** MenuImpl.java 4 Jun 2002 03:49:06 -0000 1.2
--- MenuImpl.java 12 Nov 2002 02:41:42 -0000 1.3
***************
*** 122,126 ****
boolean selected = false;
! HttpSession ses = req.getSession();
String req_parm = req.getParameter(
--- 122,126 ----
boolean selected = false;
! HttpSession ses = req.getSession(true);
String req_parm = req.getParameter(
Index: RollerMenuModel.java
===================================================================
RCS file:
/cvsroot/roller/roller/src/org/roller/presentation/tags/menu/RollerMenuModel.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -C2 -d -r1.5 -r1.6
*** RollerMenuModel.java 3 Nov 2002 20:57:13 -0000 1.5
--- RollerMenuModel.java 12 Nov 2002 02:41:42 -0000 1.6
***************
*** 186,200 ****
catch (Exception e)
{
! if ( req.getSession(false) != null )
! {
! // If we have a session, get context, and log
it
! ServletContext ctx =
req.getSession().getServletContext();
! ctx.log("ERROR getting user in menu model", e);
! }
! else
! {
! // Otherwise just spew
! e.printStackTrace();
! }
}
return params;
--- 186,192 ----
catch (Exception e)
{
! // If we have a session, get context, and log it
! ServletContext ctx = rreq.getServletContext();
! ctx.log("ERROR getting user in menu model", e);
}
return params;
-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
|