Patch #439 has been updated.
Project: izpack
Category: None
Status: Closed
Submitted by: starksm
Assigned to : starksm
Summary: Compiler refactor prototype + Pack group, installGroups
Follow-Ups:
Date: 2005-May-23 20:05
By: starksm
Comment:
Ok, I'm working on merging 439/440 after resynching.
-------------------------------------------------------
Date: 2005-May-21 02:12
By: jponge
Comment:
Scott,
Patch 439 and 440 do not apply cleanly on my side. Could you please merge them
as well as the ant task patch ? I think it will be much better if you do it.
You have also been granted some rights on the patch manager, so I assign them
to you. Tou will be able to close the patches once merged and commited.
Also, do not forget to update Versions.txt and add a line for the patches ;-)
Cheers.
-------------------------------------------------------
Date: 2005-May-15 09:09
By: starksm
Comment:
The revised patch removes the ant task changes.
-------------------------------------------------------
Date: 2005-May-15 09:05
By: starksm
Comment:
Ok, I'll submit a new ant task. The @{x} syntax can be supported at the ant
level which is where I would to deal with compile time substitution as I find
the non-dot-decimal style of property names/system properties to be an
integration problem.
-------------------------------------------------------
Date: 2005-May-15 08:00
By: mchenryc
Comment:
This should be two separate patches. Addition of install groups and Ant
integration are orthogonal.
The groups feature is a useful addition.
The Ant integration introduces semantic confusion. IzPack uses the syntax
${foo} for variables replaced at install time. Properties, replaced at compile
time, use the syntax @{foo} so they do not conflict. Ant replaces ${foo} at
compile time introducing the conflict.
Even if ant did not replace ${foo} in the CDATA, different semantics for a
single syntax, in one file, is not a good idea.
-------------------------------------------------------
Date: 2005-May-14 22:40
By: starksm
Comment:
This patch refactors the compiler into an xml configuration driven piece and an
xml independent piece. The IzPackTask task has been updated to support an
embedded install configuration using a config child element:
<target name="installer">
<echo message="Building JBossAS Installer..."/>
<izpack
output="jboss-4.0.2-installer.jar"
installerType="standard"
basedir="${jboss.dist}"
inheritAll="true"
izPackDir="${IZPACK_HOME}"
>
<property name="STACKTRACE" value="true"/>
<config>
<![CDATA[
<installation version="1.0">
...
</installation>
]]>
</config>
</izpack>
Note that the install document needs to be embedded in a CDATA element. Any ant
property references of the for ${x} in the configuration will be replaced using
the ant project properties before being passed to the compiler.
Two new attributes have been added the Pack/PackInfo classes:
group: The group the pack is associated with. The pack group identifies packs
with common functionality to allow for grouping of packs in a tree in the
TargetPanel for example.
installGroups: An association of this pack to zero or more installation groups.
An installation group is just a named collection of packs to allow for
different pack collections to be selected, for example: minimal, default, all.
The syntax for the installGroups is a comma seperated list of the group names.
Nothing has been done to make use of the group or installGroups in the
installation panels as yet.
-------------------------------------------------------
-------------------------------------------------------
For more info, visit:
http://developer.berlios.de/patch/?func=detailpatch&patch_id=439&group_id=1408
|
