|
|
[HtmlUnit] CVS Commit: src/xdocs: HtmlCheckBoxInput.setChecked() now fires: msg#00072java.htmlunit.devel
Log Message: ----------- HtmlCheckBoxInput.setChecked() now fires the JavaScript onchange event. Modified Files: -------------- htmlunit/src/test/java/com/gargoylesoftware/htmlunit/html: HtmlCheckBoxInputTest.java (http://cvs.sourceforge.net/viewcvs.py/htmlunit/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/html/HtmlCheckBoxInputTest.java) htmlunit/src/xdocs: changes.xml (http://cvs.sourceforge.net/viewcvs.py/htmlunit/htmlunit/src/xdocs/changes.xml) htmlunit/src/java/com/gargoylesoftware/htmlunit/html: HtmlCheckBoxInput.java (http://cvs.sourceforge.net/viewcvs.py/htmlunit/htmlunit/src/java/com/gargoylesoftware/htmlunit/html/HtmlCheckBoxInput.java) Revision Data ------------- Index: changes.xml =================================================================== RCS file: /cvsroot/htmlunit/htmlunit/src/xdocs/changes.xml,v retrieving revision 1.495 retrieving revision 1.496 diff -Lsrc/xdocs/changes.xml -Lsrc/xdocs/changes.xml -u -d -r1.495 -r1.496 --- src/xdocs/changes.xml +++ src/xdocs/changes.xml @@ -8,6 +8,9 @@ <body> <release version="next"> <action type="update" dev="yourgod"> + HtmlCheckBoxInput.setChecked() now fires the JavaScript onchange event. + </action> + <action type="update" dev="yourgod"> Implemented window.setTimeout(function, int) and window.setInterval(function, int) </action> <action type="update" dev="yourgod"> Index: HtmlCheckBoxInputTest.java =================================================================== RCS file: /cvsroot/htmlunit/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/html/HtmlCheckBoxInputTest.java,v retrieving revision 1.7 retrieving revision 1.8 diff -Lsrc/test/java/com/gargoylesoftware/htmlunit/html/HtmlCheckBoxInputTest.java -Lsrc/test/java/com/gargoylesoftware/htmlunit/html/HtmlCheckBoxInputTest.java -u -d -r1.7 -r1.8 --- src/test/java/com/gargoylesoftware/htmlunit/html/HtmlCheckBoxInputTest.java +++ src/test/java/com/gargoylesoftware/htmlunit/html/HtmlCheckBoxInputTest.java @@ -148,4 +148,25 @@ checkBox.setChecked(true); assertEquals("checked", checkBox.asText()); } + + /** + * @throws Exception if the test fails + */ + public void testOnchangeFires() throws Exception { + final String content = "<html><head><title>foo</title>" + + "</head><body>" + + "<form>" + + "<input type='checkbox' id='chkbox' onchange='alert(\"foo\");' />" + + "</form>" + + "</body></html>"; + + final List expectedAlerts = Arrays.asList(new String[] {"foo"}); + + final List collectedAlerts = new ArrayList(); + final HtmlPage page = loadPage(content, collectedAlerts); + final HtmlCheckBoxInput checkbox = (HtmlCheckBoxInput) page.getHtmlElementById("chkbox"); + checkbox.setChecked(true); + + assertEquals(expectedAlerts, collectedAlerts); + } } Index: HtmlCheckBoxInput.java =================================================================== RCS file: /cvsroot/htmlunit/htmlunit/src/java/com/gargoylesoftware/htmlunit/html/HtmlCheckBoxInput.java,v retrieving revision 1.23 retrieving revision 1.24 diff -Lsrc/java/com/gargoylesoftware/htmlunit/html/HtmlCheckBoxInput.java -Lsrc/java/com/gargoylesoftware/htmlunit/html/HtmlCheckBoxInput.java -u -d -r1.23 -r1.24 --- src/java/com/gargoylesoftware/htmlunit/html/HtmlCheckBoxInput.java +++ src/java/com/gargoylesoftware/htmlunit/html/HtmlCheckBoxInput.java @@ -99,6 +99,7 @@ else { removeAttribute( "checked" ); } + getPage().executeOnChangeHandlerIfAppropriate(this); } /** ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
|
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| Previous by Date: | [HtmlUnit] CVS Commit: WebClient.java: use getter and setter for easier debugging, yourgod |
|---|---|
| Next by Date: | [HtmlUnit] [ htmlunit-Feature Requests-1459704 ] addEventListener method not recognized by JS engine, SourceForge.net |
| Previous by Thread: | [HtmlUnit] CVS Commit: WebClient.java: use getter and setter for easier debugging, yourgod |
| Next by Thread: | [HtmlUnit] [ htmlunit-Feature Requests-1459704 ] addEventListener method not recognized by JS engine, SourceForge.net |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
| News | FAQ | advertise |