[HtmlUnit] [ htmlunit-Feature Requests-1438216 ] Feature to set HttpConnectionManager

Feature Requests item #1438216, was opened at 2006-02-24 17:49
Message generated for change (Settings changed) made by mguillem
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448269&aid=1438216&group_id=47038

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
Priority: 5
Submitted By: mtamme (mtamme)
>Assigned to: Marc Guillemot (mguillem)
Summary: Feature to set HttpConnectionManager

Initial Comment:
One really easy to implement an importante feature for
me would be set the HttpConnectionManger for the used
HttpClient's in HtmlUnit.
Would effect two HtmlUnit classes:

WebClient class:
  setHttpConnectionManager
  getHttpConnectionManager

HttpWebConnection class:
  httpClient_ = new HttpClient(
    getWebClient().getHttpConnectionManager());

The importance for me is to have more control over the
HTTP part of HtmlUnit.

Thanks

----------------------------------------------------------------------

>Comment By: Marc Guillemot (mguillem)
Date: 2006-02-28 19:04

Message:
Logged In: YES 
user_id=402164

Now fixed in CVS.

----------------------------------------------------------------------

Comment By: mtamme (m4nt)
Date: 2006-02-28 09:40

Message:
Logged In: YES 
user_id=1462740

Excuse me, i meant createHttpClient();

----------------------------------------------------------------------

Comment By: mtamme (m4nt)
Date: 2006-02-28 09:33

Message:
Logged In: YES 
user_id=1462740

I like the idea with the

protected HttpClient createWebClient()

method.

When i posted my HttpConnectionManager feature request, i
thought you don't mind about it. because you already have a
tight relation to HttpClient (HttpState and
CredentialsProvider). But the createWebClient() method is an
acceptable way to solve my problem.

Thanks

----------------------------------------------------------------------

Comment By: Marc Guillemot (mguillem)
Date: 2006-02-27 20:00

Message:
Logged In: YES 
user_id=402164

Would it be ok to have a 

protected HttpClient createWebClient()

in HttpWebConnection allowing you to extend
HttpWebConnection with your own implementation of
createWebClient and to set the custom WebConnection on your
WebClient?

----------------------------------------------------------------------

Comment By: Brad Clarke (yourgod)
Date: 2006-02-27 18:29

Message:
Logged In: YES 
user_id=257129

Seems like a refactoring of HttpWebConnection to use
factories for all HttpClient creation would give you the
ability to extend it for desired functionality without
needing to patch the source and without having to add
HttpClient items to the HtmlUnit API.



----------------------------------------------------------------------

Comment By: mtamme (m4nt)
Date: 2006-02-27 13:46

Message:
Logged In: YES 
user_id=1462740

If there is a new HtmlUnit version out, i am always patching
the source to be able to set the HttpConnectionManager
because i need to get control over the HttpConnections and
finally over the Socket creation to measure things like:
- connect time
- client-time
- server-response time
- read time
- write time
- bytes read
- bytes written


----------------------------------------------------------------------

Comment By: Marc Guillemot (mguillem)
Date: 2006-02-27 13:14

Message:
Logged In: YES 
user_id=402164

Can you write a few words about the need of the access to
the HttpConnectionManager?
If this is really needed, I dislike the option of adding
this property to WebClient but HttpWebConnection could be
redesigned to allow custom extension to create the HttpClient.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448269&aid=1438216&group_id=47038


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642