[jira] Resolved: (HARMONY-113) java.nio.charset.Charset should regard empty charset name properly as Illegal CharsetName

     [ http://issues.apache.org/jira/browse/HARMONY-113?page=all ]
     
Tim Ellison resolved HARMONY-113:
---------------------------------

    Resolution: Fixed

Richard,

Thanks for the patch, which looks ok.

Applied in NIO_CHAR module java.nio.Charset at repo revision 380635.
I have only used a subset of the tests that you provided, since there is no 
definition for MockCharset.

Please check that the patch was applied as you expected.


> java.nio.charset.Charset should regard empty charset name properly as Illegal 
> CharsetName
> -----------------------------------------------------------------------------------------
>
>          Key: HARMONY-113
>          URL: http://issues.apache.org/jira/browse/HARMONY-113
>      Project: Harmony
>         Type: Bug
>   Components: Classlib
>     Reporter: Richard Liang
>     Assignee: Tim Ellison
>  Attachments: charset_patch.txt
>
> I think it's caused by the different between RI 1.4.2 and RI 5.0. Three test 
> cases in JIRA#57  should be updated accordingly.
>       public void testIsSupported_EmptyString() {
>               try {
>                       Charset.isSupported("");
>             fail("Should throw IllegalCharsetNameException!");
>               } catch (IllegalCharsetNameException e) {
>                       //
>               }
>       }
>       public void testConstructor_EmptyCanonicalName() {
>               try {
>                       new MockCharset("", new String[0]);
>             fail("Should throw IllegalCharsetNameException!");
>               } catch (IllegalCharsetNameException e) {
>                       //
>               }
>       }
>       public void testConstructor_EmptyAliases() {
>               try {
>                       new MockCharset("mockChar", new String[] { "" });
>             fail("Should throw IllegalCharsetNameException!");
>               } catch (IllegalCharsetNameException e) {
>                       //
>               }
>       }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira