Re: Problem still appears in List

This is a multi-part message in MIME format.

Roth, Thomas schreef:

i use FindBug Eclipse Plugin. I've had the problem (..) After the following steps the problem still appears in the problem view list (..)

 

I've had to clean and rebuild the project. After this the problem no longer appears in the list.

Looks like you, too, are running into:

  http://sourceforge.net/tracker/index.php?func=detail&aid=1711828&group_id=96405&atid=614693

I worked around this by changing in FindbugsWorker.java:

if (Util.isJavaArtifact(res)) {
                res.deleteMarkers(
                    FindBugsMarker.NAME,
                    true,
                    IResource.DEPTH_INFINITE);
                IJavaElement ije = JavaCore.create(res);
                if (ije instanceof ClassFile)
                {
                    ClassFile cf = (ClassFile) ije;
                    String className = cf.getType().getFullyQualifiedName('.');
                    FindbugsPlugin.removeFromBugCollection(className, project, monitor);
                }
            }

and adding to FindbugsPlugin.java:

public static void removeFromBugCollection(String className, IProject project, IProgressMonitor monitor) throws CoreException {
            SortedBugCollection bc = getBugCollection(project, monitor);
            for (BugInstance bi : new ArrayList<BugInstance>(bc.getCollection()))
            {
                if (bi.getPrimaryClass().getClassName().indexOf(className) != -1)
                {
                    bc.remove(bi);
                }
            }
            project.setSessionProperty(SESSION_PROPERTY_BUG_COLLECTION, bc);
    }

This seems like a reasonable workaround for the short time - though it seems cf.getType().getFullyQualifiedName('.') does not, actually, return the full name (with package name), so this might potentially remove too many markers.

I probably won't have time to finish the solution and turn it into a proper patch the coming week, so if someone wants to take this up, please go ahead :)


Arnout