Re: New Detector for static use of Calendar and DateFormat

Hi Daniel,

On 4/17/07, Daniel Schneller <dannyschneller@xxxxxxxxxxx> wrote:
> In the meantime I am still open for pointers on how to detect whether
> I am in a synchronized block. That would help to eliminate some false
> positives.

LockDataflow can answer that question.

Given a Location (a particular bytecode instruction within a particular
basic block):

 LockDataflow ld = classContext.getLockDataflow(method);

 Location loc = ...
 LockSet lockSet = ld.getFactAtLocation(loc);
 if (lockSet.getNumLockedValues() > 0) {
   // location is in a synchronized block or in synchronized method
 }

Since you have a BytecodeScanningDetector, then you will need to do
a bit of work to get Location(s) for a bytecode offset.
Use the getCFG() method of ClassContext to get the CFG for
the method, then call the getLocationsContainingInstructionWithOffset(int)
method passing the bytecode offset as an argument.  That
gives you a collection of Locations matching that offset.
(A single bytecode instruction can be considered as multiple
Locations because of JSR subroutines reachable via multiple
paths.)

Hope this helps!

-Dave