logo       

fusing line numbers for fb markers in Eclipse plugin: msg#00072

java.findbugs.general

Subject: fusing line numbers for fb markers in Eclipse plugin

Hi,

I am looking trough FindBugs reports generated by Eclipse plugin. Here is

RCN: Nullcheck of optionValues at line 381 of value previously dereferenced in org.eclipse.mylar.internal.bugzilla.core.BugzillaRepositoryConnector.setupNewBugAttributes(org.eclipse.mylar.tasks.core.TaskRepository,NewBugzillaTaskData) org.eclipse.mylar.bugzilla.core/src/org/eclipse/mylar/internal/bugzilla/core BugzillaRepositoryConnector.java line 378

That error shown for the following code fragment (Java 5)

378 for (String option : optionValues) {
379 a.addOption(option, option);
380 }
381 if (optionValues != null && optionValues.size() > 0) {
382 a.setValue(optionValues.get(optionValues.size() - 1));
383 }

Wouldn't it be more appropriate to have error marker at line 381 and refer to line 378 in the error text?

Thanks

Eugene




<Prev in Thread] Current Thread [Next in Thread>
Google Custom Search

News | FAQ | advertise