logo       

Re: FindBugs 1.1.2-rc4: msg#00041

java.findbugs.general

Subject: Re: FindBugs 1.1.2-rc4


On Dec 18, 2006, at 3:42 PM, Andrei Loskutov wrote:

On Sun, 17 Dec 2006 22:06:08 +0100, Bill Pugh <pugh@xxxxxxxxxx> wrote:

Hopefully, the last release candidate before 1.1.2 final (of course, I said that last time).
Please check and see if it works for you and resolves any issues you had with the previous release.

Hi Bill,

1) I've tried 1.1.2-rc4 which was built on 17 december, but it seems that Eclipse plugin (http://findbugs.cs.umd.edu/eclipse- candidate) is still based on the *older* findbugs source code or includes older findbugs binaries.
Especially I've expected to see my patch to UserPreferences (http:// code.google.com/p/findbugs/issues/detail?id=11), which was applied to the FindBugs code in SVN at 16 december but the behavoir is still unchanged in 1.1.2-rc4.

Is it by mistake *only* for this class, or is there a general build problem for Eclipse plugin distribution?

As far as I can tell, 1.1.2-rc4 contains the new code, including the new code for UserPreferences.

Look in the findbugs.jar file. If you see:

edu/umd/cs/findbugs/config/UserPreferences$1.class

then the code you have contains the most recent version of UserPreferences (the patch you provided adds an inner class). Please see if you can identify the issue here, I'd like to get it resolved.


2) Another (small) Eclipse build problem is that the
eclipse\plugins\edu.umd.cs.findbugs.plugin.eclipse_1.1.2.20061217 \plugin
folder contains /tmp directory with the entire content of coreplugin.jar (over 1.7 MB on a disk, still ~0.6 MB zipped). It seems that this make error was introduced with 1.1.2, because 1.1.1 release doesn' have /tmp inside.


Fixed, as well as deleting some other cruft.


3) I see also that you still using ASM 3.0_RC1 libraries, but Eric had already released final 3.0 (http://forge.objectweb.org/projects/ asm/).

updated.


P.S.
I'm not sure, but could you check if your mail server/spam filter rejects all the mails from me adressed directly to <pugh@xxxxxxxxxx>?

I don't think I was loosing your email (just insanely busy), but I've now whitelisted you.

Bill


--
Kind regards,
mit freundlichen Grüßen
Andrei Loskutov

@Home: http://andrei.gmxhome.de
Hinweis: diese Nachricht besteht nur aus den wiederverwertbaren Bits.
_______________________________________________
Findbugs-discuss mailing list
Findbugs-discuss@xxxxxxxxxxxxxxxxxx
http://mailman.cs.umd.edu/mailman/listinfo/findbugs-discuss




<Prev in Thread] Current Thread [Next in Thread>
Google Custom Search

News | FAQ | advertise